Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AKS addon azure-keyvault-secrets-provider #12783

Closed
jkroepke opened this issue Jul 30, 2021 · 4 comments · Fixed by #14308
Closed

Support for AKS addon azure-keyvault-secrets-provider #12783

jkroepke opened this issue Jul 30, 2021 · 4 comments · Fixed by #14308

Comments

@jkroepke
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support the AKS addon azure-keyvault-secrets-provider

New or Affected Resource(s)

  • azurerm_kubernetes_cluster

Potential Terraform Configuration

azurerm_kubernetes_cluster {
  addon_profile {
    keyvault_secrets {
      enabled = true
      secret_rotation = true
    }
  }  
}

References

https://docs.microsoft.com/en-us/azure/aks/csi-secrets-store-driver

@nerddtvg
Copy link
Contributor

nerddtvg commented Oct 4, 2021

Even if the provider doesn't support enabling/configuring the Key Vault CSI driver, perhaps only exporting the values would be okay? Referencing the data exported from the addon_profile block for that addon is critical for referencing the user assigned managed identity it enables and setting the Key Vault ACLs appropriately.

    "addonProfiles": {
      "azureKeyvaultSecretsProvider": {
        "enabled": true,
        "config": {
          "enableSecretRotation": "true"
        },
        "identity": {
          "resourceId": "/subscriptions/aaaaaaaa-bbbb-cccc-dddd-ffffffffffff/resourcegroups/MC_resource_group/providers/Microsoft.ManagedIdentity/userAssignedIdentities/azurekeyvaultsecretsprovider-name",
          "clientId": "aaaaaaaa-bbbb-cccc-dddd-ffffffffffff",
          "objectId": "aaaaaaaa-bbbb-cccc-dddd-ffffffffffff"
        }
      }

Last week, the driver had a pre-release for version v1.0.0 with rc0. The structure and function is probably not going to change much before go-live.

https://github.com/Azure/secrets-store-csi-driver-provider-azure/releases/tag/v1.0.0-rc.0

@deepak-malhotra
Copy link

deepak-malhotra commented Nov 2, 2021

The pre-req for Secret store driver is CSI being enabled. CSI is default storage driver from AKS 1.21 and the Secret store driver is also GA since November 2021.

https://docs.microsoft.com/en-us/azure/aks/csi-storage-drivers
https://docs.microsoft.com/en-us/azure/aks/csi-secrets-store-driver

@github-actions
Copy link

This functionality has been released in v2.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants