Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: azurerm_data_factory_dataset_binary - Make blob path/filename optional #12676

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Bugfix: azurerm_data_factory_dataset_binary - Make blob path/filename optional #12676

merged 1 commit into from
Jul 27, 2021

Conversation

henrymcconville
Copy link
Contributor

@henrymcconville henrymcconville commented Jul 21, 2021

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/datafactory/data_factory_dataset_binary_resource_test.go  -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataFactoryDatasetBinary_blob
=== PAUSE TestAccDataFactoryDatasetBinary_blob
=== RUN   TestAccDataFactoryDatasetBinary_blob_with_filepath
=== PAUSE TestAccDataFactoryDatasetBinary_blob_with_filepath
=== RUN   TestAccDataFactoryDatasetBinary_http
=== PAUSE TestAccDataFactoryDatasetBinary_http
=== RUN   TestAccDataFactoryDatasetBinary_sftp
=== PAUSE TestAccDataFactoryDatasetBinary_sftp
=== RUN   TestAccDataFactoryDatasetBinary_sftpComplete
=== PAUSE TestAccDataFactoryDatasetBinary_sftpComplete
=== CONT  TestAccDataFactoryDatasetBinary_blob
=== CONT  TestAccDataFactoryDatasetBinary_sftp
=== CONT  TestAccDataFactoryDatasetBinary_http
=== CONT  TestAccDataFactoryDatasetBinary_sftpComplete
=== CONT  TestAccDataFactoryDatasetBinary_blob_with_filepath
--- PASS: TestAccDataFactoryDatasetBinary_http (110.23s)
--- PASS: TestAccDataFactoryDatasetBinary_sftpComplete (113.74s)
--- PASS: TestAccDataFactoryDatasetBinary_sftp (115.86s)
--- PASS: TestAccDataFactoryDatasetBinary_blob_with_filepath (126.59s)
--- PASS: TestAccDataFactoryDatasetBinary_blob (127.02s)
PASS
ok  	command-line-arguments	128.510s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrymcconville - LGTM 🚀

@katbyte katbyte added this to the v2.70.0 milestone Jul 27, 2021
@katbyte katbyte merged commit e45c594 into hashicorp:master Jul 27, 2021
katbyte added a commit that referenced this pull request Jul 27, 2021
@henrymcconville henrymcconville deleted the adf-binary-dataset-required-fields-fix branch July 29, 2021 11:27
@github-actions
Copy link

This functionality has been released in v2.70.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants