Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource "azurerm_data_factory_data_flow" #12588

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jul 14, 2021

Comment on lines +281 to +219
linked_service {
name = azurerm_data_factory_linked_custom_service.test.name
parameters = {
"Key1" = "value1"
}
}

schema_linked_service {
name = azurerm_data_factory_linked_custom_service.test.name
parameters = {
"Key1" = "value1"
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these seem to be the exact same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked the service team, they says that schema_linked_service is mainly for Common Data Model. it allows the data flow to read schema info from schema_linked_service and read data from linked_service. In this way data and schema metadata could be placed in different location.

To simplify the acctest, I used the same linkedservice for linked_service and schema_linked_service. Below are some screenshot of Common Data Model in portal:

image

image

@njuCZ
Copy link
Contributor Author

njuCZ commented Jul 19, 2021

Hi @katbyte thanks for your review, I have rebased this PR.

@ms-henglu
Copy link
Contributor

@katbyte , hi, could you please take another look at this PR? Thanks!

@katbyte katbyte modified the milestones: v2.70.0, v2.71.0 Jul 30, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 🍰

@katbyte katbyte merged commit a92ec7a into hashicorp:master Jul 30, 2021
katbyte added a commit that referenced this pull request Jul 30, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for creating Data Factory Data flows
4 participants