Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_nat_gateway_public_ip_prefix_association #12353

Merged
merged 1 commit into from
Jun 24, 2021
Merged

New resource: azurerm_nat_gateway_public_ip_prefix_association #12353

merged 1 commit into from
Jun 24, 2021

Conversation

favoretti
Copy link
Collaborator

In order to align behavior between Public IP association and Public IP
Prefix association to NAT Gateway I'd like to introduce a new virtual
resource (similar to the one added in #6450 and #7106).

At the same time adding deprecation warning to public_ip_prefix_ids in
NAT Gateway.

$ TF_ACC=1 go test -v ./azurerm/internal/services/network -timeout=1000m -run='TestAccNatGatewayPublicIpPrefixAssociation'
=== RUN   TestAccNatGatewayPublicIpPrefixAssociation_basic
=== PAUSE TestAccNatGatewayPublicIpPrefixAssociation_basic
=== RUN   TestAccNatGatewayPublicIpPrefixAssociation_updateNatGateway
=== PAUSE TestAccNatGatewayPublicIpPrefixAssociation_updateNatGateway
=== RUN   TestAccNatGatewayPublicIpPrefixAssociation_requiresImport
=== PAUSE TestAccNatGatewayPublicIpPrefixAssociation_requiresImport
=== RUN   TestAccNatGatewayPublicIpPrefixAssociation_deleted
=== PAUSE TestAccNatGatewayPublicIpPrefixAssociation_deleted
=== CONT  TestAccNatGatewayPublicIpPrefixAssociation_basic
=== CONT  TestAccNatGatewayPublicIpPrefixAssociation_deleted
=== CONT  TestAccNatGatewayPublicIpPrefixAssociation_requiresImport
=== CONT  TestAccNatGatewayPublicIpPrefixAssociation_updateNatGateway
--- PASS: TestAccNatGatewayPublicIpPrefixAssociation_deleted (149.71s)
--- PASS: TestAccNatGatewayPublicIpPrefixAssociation_basic (169.66s)
--- PASS: TestAccNatGatewayPublicIpPrefixAssociation_requiresImport (173.71s)
--- PASS: TestAccNatGatewayPublicIpPrefixAssociation_updateNatGateway (231.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network	232.883s

In order to align behavior between Public IP association and Public IP
Prefix association to NAT Gateway I'd like to introduce a new virtual
resource (similar to the one added in #6450 and #7106).

At the same time adding deprecation warning to `public_ip_prefix_ids` in
NAT Gateway.

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/network -timeout=1000m -run='TestAccNatGatewayPublicIpPrefixAssociation'
=== RUN   TestAccNatGatewayPublicIpPrefixAssociation_basic
=== PAUSE TestAccNatGatewayPublicIpPrefixAssociation_basic
=== RUN   TestAccNatGatewayPublicIpPrefixAssociation_updateNatGateway
=== PAUSE TestAccNatGatewayPublicIpPrefixAssociation_updateNatGateway
=== RUN   TestAccNatGatewayPublicIpPrefixAssociation_requiresImport
=== PAUSE TestAccNatGatewayPublicIpPrefixAssociation_requiresImport
=== RUN   TestAccNatGatewayPublicIpPrefixAssociation_deleted
=== PAUSE TestAccNatGatewayPublicIpPrefixAssociation_deleted
=== CONT  TestAccNatGatewayPublicIpPrefixAssociation_basic
=== CONT  TestAccNatGatewayPublicIpPrefixAssociation_deleted
=== CONT  TestAccNatGatewayPublicIpPrefixAssociation_requiresImport
=== CONT  TestAccNatGatewayPublicIpPrefixAssociation_updateNatGateway
--- PASS: TestAccNatGatewayPublicIpPrefixAssociation_deleted (149.71s)
--- PASS: TestAccNatGatewayPublicIpPrefixAssociation_basic (169.66s)
--- PASS: TestAccNatGatewayPublicIpPrefixAssociation_requiresImport (173.71s)
--- PASS: TestAccNatGatewayPublicIpPrefixAssociation_updateNatGateway (231.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network	232.883s
```
@favoretti
Copy link
Collaborator Author

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@katbyte katbyte added this to the v2.65.0 milestone Jun 24, 2021
@katbyte katbyte merged commit b6580d6 into hashicorp:master Jun 24, 2021
katbyte added a commit that referenced this pull request Jun 24, 2021
@github-actions
Copy link

This functionality has been released in v2.65.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants