Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"azurerm_data_factory" - migrate to the correct ID format when resource name is in upper case #12128

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jun 9, 2021

fix #12099

the reason caused this issue:
image
when created a data factory with upper name, in the response body, the name is right, however, the name is in lower case in the id.

When refactor with id parser, we should migrate the id format first.

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @njuCZ, thanks for this fix. I've pushed another commit to include uppercase characters in the resource names in the acctests. Assuming those pass, this looks good to merge!

@manicminer manicminer added this to the v2.65.0 milestone Jun 18, 2021
@manicminer
Copy link
Contributor

Test results

Screenshot 2021-06-18 at 19 40 06

@manicminer manicminer merged commit ee13405 into hashicorp:master Jun 18, 2021
manicminer added a commit that referenced this pull request Jun 18, 2021
@github-actions
Copy link

This functionality has been released in v2.65.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-factory forces replacement due to name change even with no changes
3 participants