Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_static_site: Add support for tags attribute #11849

Merged
merged 2 commits into from
May 25, 2021
Merged

azurerm_static_site: Add support for tags attribute #11849

merged 2 commits into from
May 25, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented May 25, 2021

$ TF_ACC=1 go test -v ./azurerm/internal/services/web -timeout=1000m -run='TestAccAzureStaticSite_basic'
2021/05/25 10:38:13 [DEBUG] not using binary driver name, it's no longer needed
2021/05/25 10:38:13 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccAzureStaticSite_basic
=== PAUSE TestAccAzureStaticSite_basic
=== CONT  TestAccAzureStaticSite_basic
--- PASS: TestAccAzureStaticSite_basic (156.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web	158.219s

Fixes #11837

Copy link
Collaborator

@aristosvo aristosvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we'd need a basicUpdate test to cover the complete functionality

@ghost ghost added size/M and removed size/XS labels May 25, 2021
@favoretti
Copy link
Collaborator Author

$ TF_ACC=1 go test -v ./azurerm/internal/services/web -timeout=1000m -run='TestAccAzureStaticSite_basicUpdate'
2021/05/25 17:03:45 [DEBUG] not using binary driver name, it's no longer needed
2021/05/25 17:03:45 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccAzureStaticSite_basicUpdate
=== PAUSE TestAccAzureStaticSite_basicUpdate
=== CONT  TestAccAzureStaticSite_basicUpdate
--- PASS: TestAccAzureStaticSite_basicUpdate (213.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web	215.202s

@aristosvo done.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.61.0 milestone May 25, 2021
@mbfrahry mbfrahry merged commit ac087a8 into hashicorp:master May 25, 2021
mbfrahry added a commit that referenced this pull request May 25, 2021
@ghost
Copy link

ghost commented May 27, 2021

This has been released in version 2.61.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.61.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for tags on azurerm_static_site
4 participants