Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_sql_container: add analytical_storage_ttl argument #11655

Merged
merged 1 commit into from
May 14, 2021
Merged

azurerm_cosmosdb_sql_container: add analytical_storage_ttl argument #11655

merged 1 commit into from
May 14, 2021

Conversation

favoretti
Copy link
Collaborator

$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=1000m -run 'TestAccCosmosDbSqlContainer_analyticalStorageTTL'
2021/05/11 10:28:44 [DEBUG] not using binary driver name, it's no longer needed
2021/05/11 10:28:47 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccCosmosDbSqlContainer_analyticalStorageTTL
=== PAUSE TestAccCosmosDbSqlContainer_analyticalStorageTTL
=== CONT  TestAccCosmosDbSqlContainer_analyticalStorageTTL
--- PASS: TestAccCosmosDbSqlContainer_analyticalStorageTTL (1009.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	1017.167s

image

Fixes #10198

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=1000m -run 'TestAccCosmosDbSqlContainer_analyticalStorageTTL'
2021/05/11 10:28:44 [DEBUG] not using binary driver name, it's no longer needed
2021/05/11 10:28:47 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccCosmosDbSqlContainer_analyticalStorageTTL
=== PAUSE TestAccCosmosDbSqlContainer_analyticalStorageTTL
=== CONT  TestAccCosmosDbSqlContainer_analyticalStorageTTL
--- PASS: TestAccCosmosDbSqlContainer_analyticalStorageTTL (1009.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	1017.167s

```

Fixes #10198
@favoretti favoretti changed the title azurerm_consmosdb_sql_container: add analytical_storage_ttl argument azurerm_cosmosdb_sql_container: add analytical_storage_ttl argument May 11, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte added this to the v2.59.0 milestone May 14, 2021
@katbyte katbyte merged commit 0de88db into hashicorp:master May 14, 2021
katbyte added a commit that referenced this pull request May 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.59.0"
}
# ... other configuration ...

favoretti added a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
…nt (hashicorp#11655)

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=1000m -run 'TestAccCosmosDbSqlContainer_analyticalStorageTTL'
2021/05/11 10:28:44 [DEBUG] not using binary driver name, it's no longer needed
2021/05/11 10:28:47 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccCosmosDbSqlContainer_analyticalStorageTTL
=== PAUSE TestAccCosmosDbSqlContainer_analyticalStorageTTL
=== CONT  TestAccCosmosDbSqlContainer_analyticalStorageTTL
--- PASS: TestAccCosmosDbSqlContainer_analyticalStorageTTL (1009.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	1017.167s

```

Fixes hashicorp#10198
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for analytical store in azurerm_cosmosdb_sql_container
2 participants