"azurerm_kubernetes_cluster" - supports "max_node_provisioning_time","max_unready_percentage" and "max_unready_nodes"

[njuCZ]

This PR adds support for the max_node_provision_time, max_total_unready_percentage and ok_total_unready_count property in the auto_scaler_profile block for azurerm_kubernetes_cluster.

As per https://docs.microsoft.com/en-us/azure/aks/cluster-autoscaler#using-the-autoscaler-profile

the original acctest TestAccKubernetesCluster_autoScalingProfile fails because the version "1.19.6" is not available in the westeurope

[magodo]

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

[magodo]

LGTM 👍

[magodo]

@njuCZ About the default values, I'm a bit concerned if some existing resource has different default values being set when they created the resource with old provider, then they'll get a diff in the new provider. Though this is not likely to happen if the service keeps the behavior consistent.

[njuCZ]

@magodo the simplest way is to make them typeString, empty string will make the backend service return the default value. This is a little common for aks. But I also agrees that exlipcit type is more helpful. To make it TypeInt, we should set a default value, because 0 is also a valid value.

[magodo]

If they are O+C, I assume the default is not necessary?

[njuCZ]

If it's TypeString, O+C has no problem. but if we set it as TypeInt, it will have a default value 0, 0 is a valid value for this property, and the backend service will think client want to set it as 0 and does not return the default value

[magodo]

Ah.. Because those properties are inside a nested block, which means there is no way to tell whether they are omitted in the config or not..

[katbyte]

Thanks @njuCZ - just a couple comments

[njuCZ]

@katbyte thanks for your opinion, I have renamed those fields.

[katbyte]

Thanks @njuCZ - LGTM 👍

[ghost]

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.