Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_eventgrid_system_topic - remove strict validation on topic_type #11352

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

MattiasAng
Copy link
Contributor

Fixes #11308

Instead of doing validation of every topic type I think this should be changed to letting API handle it as the error message is very clear. This would not require changes to any code when new topic types are released.

Error message on a system topic that is not available:
Original Error: Code="InvalidRequest" Message="Unrecognized topic type justtesting in system topic properties."

@ghost ghost added the size/XS label Apr 16, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.57.0 milestone Apr 16, 2021
@mbfrahry mbfrahry changed the title azurerm_eventgrid_system_topic - change validation on topic_type azurerm_eventgrid_system_topic - remove strict validation on topic_type Apr 16, 2021
@mbfrahry mbfrahry merged commit 388ac13 into hashicorp:master Apr 16, 2021
mbfrahry added a commit that referenced this pull request Apr 16, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_eventgrid_system_topic to support topic_type "Microsoft.PolicyInsights.PolicyStates"
2 participants