-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_mssql_job_agent
#11248
Conversation
add basic mssql_job_agent
…astic-job-agent # Conflicts: # azurerm/internal/services/mssql/client/client.go # azurerm/internal/services/mssql/resourceids.go
…ctly accepts both `ManagedIdentity` and `System` hashicorp#11222
* implementation of resource api management email template * added missing ForceNew and documentation for template_name to have proper behaviour. added acc tests. * implemented review findings * removed exporting of apim email template parameters
This data source is a special case where the Resource Group name can either be specified or looked up, so we need to set the ID once we're sure we've got the Resource Group, else the segment will be empty in the Resource ID. Fixes hashicorp#11220
…1-04-09 (hashicorp#11237) More details are in hashicorp#11231, although it's hard for us to do much about this ahead of time unfortunately due to the inability to test these changes (and confirm which breaking changes are necessary), as such giving some notice this is happening is the most helpful thing we can do at the moment.
…apping_rule_name` and `data_format` (hashicorp#11157) zurerm_eventgrid_data_connection: add support for table_name, mapping_rule_name and data_format $ make acctests SERVICE='kusto' TESTARGS='-run=TestAccKustoEventGridDataConnection_mappingRule' TESTTIMEOUT='600m' ==> Checking that code complies with gofmt requirements... ==> Checking that Custom Timeouts are used... ==> Checking that acceptance test packages are used... TF_ACC=1 go test -v ./azurerm/internal/services/kusto -run=TestAccKustoEventGridDataConnection_mappingRule -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc" 2021/03/30 16:20:12 [DEBUG] not using binary driver name, it's no longer needed 2021/03/30 16:20:12 [DEBUG] not using binary driver name, it's no longer needed === RUN TestAccKustoEventGridDataConnection_mappingRule === PAUSE TestAccKustoEventGridDataConnection_mappingRule === CONT TestAccKustoEventGridDataConnection_mappingRule --- PASS: TestAccKustoEventGridDataConnection_mappingRule (1647.62s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto 1648.919s Fixes hashicorp#10977
…astic-job-agent # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @r0bnet! This PR looks good but it seems like there are some extra bits here that aren't tied to this resource.
We should be good to go once that is taken care of and we talk through the one comment I left!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Job Credential resource as part of the Elastic Job Agents. see: #11248
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Adds a new resource for: Elastic SQL Job Agent
The resource itself is very limited so additional resources (e.g. Shared Credential, Job, Steps, Target Groups etc.) will hopefully follow.