azurerm_hpc_cache - support for ntp_server and dns

[magodo]

Support ntp_server and dns_setting for azurerm_hpc_cache.

[tombuildsstuff]

hey @magodo

Thanks for this PR.

I've taken a look through and left some comments inline but on the whole this looks pretty good - if we can fix those comments up then we should be able to take another look.

Thanks!

[magodo]

I've updated per comment, please take another look.

Test Result

💤 TF_ACC=1 go test ./azurerm/internal/services/hpccache -v -run="TestAccHPCCache_ntpServer|TestAccHPCCache_dnsSetting" -timeout=1h
2021/04/08 10:01:03 [DEBUG] not using binary driver name, it's no longer needed
2021/04/08 10:01:04 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccHPCCache_ntpServer
=== PAUSE TestAccHPCCache_ntpServer
=== RUN   TestAccHPCCache_dnsSetting
=== PAUSE TestAccHPCCache_dnsSetting
=== CONT  TestAccHPCCache_ntpServer
=== CONT  TestAccHPCCache_dnsSetting
--- PASS: TestAccHPCCache_ntpServer (1760.56s)
--- PASS: TestAccHPCCache_dnsSetting (1930.41s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hpccache    1932.010s

[tombuildsstuff]

LGTM - thanks for pushing those changes @magodo

[ghost]

This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.55.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!