Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_database - support for the geo_backup_enabled property #11177

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

MoAhuja
Copy link
Contributor

@MoAhuja MoAhuja commented Mar 31, 2021

=== RUN TestAccMsSqlDatabase_geoBackupPolicy
=== PAUSE TestAccMsSqlDatabase_geoBackupPolicy
=== CONT TestAccMsSqlDatabase_geoBackupPolicy
--- PASS: TestAccMsSqlDatabase_geoBackupPolicy (550.61s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/mssql 551.681s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @MoAhuja - overall this looks good and i've left a couple comments inline to address

@MoAhuja MoAhuja force-pushed the feature/SqlGeoBackupPolicies branch from 46066d3 to d108227 Compare April 6, 2021 17:03
@MoAhuja MoAhuja requested a review from katbyte April 6, 2021 18:54
@MoAhuja
Copy link
Contributor Author

MoAhuja commented Apr 6, 2021

@katbyte Thanks for the review. I've made the suggested adjustments.

@ghost ghost removed the waiting-response label Apr 6, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MoAhuja - LGTM 👍

@katbyte katbyte added this to the v2.56.0 milestone Apr 13, 2021
@katbyte katbyte merged commit 52f7d93 into hashicorp:master Apr 13, 2021
@katbyte katbyte changed the title Manage Geo backup policy for Data warehouse DBs azurerm_mssql_database - support for the geo_backup_enabled property Apr 13, 2021
katbyte added a commit that referenced this pull request Apr 13, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 2.56.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.56.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants