Implementation of TDE for MS SQL Server

[MoAhuja]

Fixes #87

TF_ACC=1 go test -v ./azurerm/internal/services/mssql -run=TestAccMsSqlServerTransparentDataEncryption -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/29 14:47:59 [DEBUG] not using binary driver name, it's no longer needed
2021/03/29 14:47:59 [DEBUG] not using binary driver name, it's no longer needed
=== RUN TestAccMsSqlServerTransparentDataEncryption_byok
=== PAUSE TestAccMsSqlServerTransparentDataEncryption_byok
=== RUN TestAccMsSqlServerTransparentDataEncryption_systemManaged
=== PAUSE TestAccMsSqlServerTransparentDataEncryption_systemManaged
=== RUN TestAccMsSqlServerTransparentDataEncryption_update
=== PAUSE TestAccMsSqlServerTransparentDataEncryption_update
=== CONT TestAccMsSqlServerTransparentDataEncryption_byok
=== CONT TestAccMsSqlServerTransparentDataEncryption_update
=== CONT TestAccMsSqlServerTransparentDataEncryption_systemManaged
2021/03/29 14:48:04 [DEBUG] TF_ACCTEST_REATTACH set to 1 and acctest.TestHelper is not nil, using reattach-based testing
--- PASS: TestAccMsSqlServerTransparentDataEncryption_systemManaged (246.96s)
--- PASS: TestAccMsSqlServerTransparentDataEncryption_byok (491.30s)
--- PASS: TestAccMsSqlServerTransparentDataEncryption_update (523.55s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/mssql 523.850s

[jackofallops]

Hi @MoAhuja - Thanks for this, it's off to a good start. I've left some comments below that I think need to be addressed before continuing to review. If you can fix those up, I'll continue asap.
Thanks!

[MoAhuja]

@jackofallops thanks for the review! I've made the changes you suggested and it's ready for another review. Thanks.

[jackofallops]

Hi @MoAhuja - Thanks for the quick turn-around on the changes. There's a couple more below, in particular the behaviour of the resource Delete. Again, I'll loop back as quickly as I can once these are addressed.

[MoAhuja]

@jackofallops Just an FYI, I rebased on top of the latest changes from master as there were some conflicts in the mssql clients.go file.

[manicminer]

Hi @MoAhuja, thanks for addressing @jackofallops' earlier comments. I've rebased and pushed the branch to resolve the merge conflict, and the acceptance tests look good and are passing 🎉

I have a few additional comments inline - if you can take a look at these then this should be good to merge. Thanks!

[manicminer]

Test passing

[ghost]

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.