Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ASK hex encoding/decoding attribute to create a Content Key Policy for Media Services #10684

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Fixing ASK hex encoding/decoding attribute to create a Content Key Policy for Media Services #10684

merged 2 commits into from
Feb 24, 2021

Conversation

jcanizalez
Copy link
Contributor

Hello,

fixes #10662

Following microsoft documentation to handle ASK for Fairplay in content key policy, I did changes to encode/decode ASK
https://docs.microsoft.com/en-us/azure/media-services/latest/fairplay-license-overview

TF_ACC=1 go test -v ./azurerm/internal/services/media/tests/ -run=TestAccMediaContentKeyPolicy_complete -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccMediaContentKeyPolicy_complete
=== PAUSE TestAccMediaContentKeyPolicy_complete
=== CONT TestAccMediaContentKeyPolicy_complete
--- PASS: TestAccMediaContentKeyPolicy_complete (145.96s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/media/tests 146.049s

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcanizalez Thanks for this fix, this LGTM 👍

Test results

Screenshot 2021-02-24 at 08 46 01

@manicminer manicminer added this to the v2.49.0 milestone Feb 24, 2021
@manicminer manicminer merged commit c42f065 into hashicorp:master Feb 24, 2021
manicminer added a commit that referenced this pull request Feb 24, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@jcanizalez jcanizalez deleted the fix_content_key_policy branch March 3, 2021 23:50
@ghost
Copy link

ghost commented Mar 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is not possible to use a real ASK to create a Content Key Policy for Media Services
2 participants