Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_logger: add resource_id attribute #10652

Merged

Conversation

patst
Copy link
Contributor

@patst patst commented Feb 19, 2021

This adds the link to a resource to the logger configuration (#10548). This way you can jump in the Azure Portal to the configured logger.

I wasn't sure about the naming (resource_id), maybe it could be more prescriptive.

The test case passed:

make testacc TEST='./azurerm/internal/services/apimanagement/api_management_logger_resource_test.go' TESTARGS='-run=TestAccApiManagementLogger_complete' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/apimanagement/api_management_logger_resource_test.go -v -run=TestAccApiManagementLogger_complete -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccApiManagementLogger_complete
=== PAUSE TestAccApiManagementLogger_complete
=== CONT  TestAccApiManagementLogger_complete
--- PASS: TestAccApiManagementLogger_complete (2757.20s)
PASS
ok      command-line-arguments  2759.035s

Fixes #10548

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @patst

Thanks for this PR - I've taken a look through and left some comments inline, but this is otherwise looking good - if we can fix those up then this should be good to go 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v2.49.0 milestone Feb 22, 2021
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patst for the changes. This LGTM now 👍

@tombuildsstuff tombuildsstuff dismissed their stale review February 25, 2021 17:59

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit 3a0a778 into hashicorp:master Feb 25, 2021
tombuildsstuff added a commit that referenced this pull request Feb 25, 2021
@patst patst deleted the 10548-apim-app-insight-resourceid branch February 25, 2021 19:47
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api management logger doesn't set the application insights resource id
3 participants