r/azurerm_eventgrid_event_subscription - advanced_filter MaxItems increase from 5 to 25 #10625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #10620
It would be nice to implement validation function to verify that total number of values inside advanced_filter block <= 25.
As a maximum of total number of advanced filter values allowed on event subscription is 25.
Any guidance on optimal approach (where to inject validation function for advanced_filter block) is welcomed.
make testacc TEST=./azurerm/internal/services/eventgrid TESTARGS='-run=TestAccEventGridEventSubscription_advancedFilterMaxItems'make testacc TEST=./azurerm/internal/services/eventgrid/eventgrid_event_subscription_resource_test.go TESTARGS='-run=TestAccEventGridEventSubscription_advancedFilterMaxItems'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/eventgrid/eventgrid_event_subscription_resource_test.go -v -run=TestAccEventGridEventSubscription_advancedFilterMaxItems -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccEventGridEventSubscription_advancedFilterMaxItems
=== PAUSE TestAccEventGridEventSubscription_advancedFilterMaxItems
=== CONT TestAccEventGridEventSubscription_advancedFilterMaxItems
--- PASS: TestAccEventGridEventSubscription_advancedFilterMaxItems (159.80s)
PASS
ok command-line-arguments 159.874s
make testacc TEST=./azurerm/internal/services/eventgrid/eventgrid_system_topic_event_subscription_resource_test.go TESTARGS='-run=TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/eventgrid/eventgrid_system_topic_event_subscription_resource_test.go -v -run=TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems
=== PAUSE TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems
=== CONT TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems
--- PASS: TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems (178.36s)
PASS
ok command-line-arguments 178.438s