-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_data_factory - support for the customer_managed_key_id property #10502
Conversation
I need some help with this PR 😢
The apply works and I can manually verify that ADF contains the user identity. |
And here is why we are getting the non-empty plan:
The root cause of this is that the user assigned identity resource is not returning its ID in proper casing - we could fix this by introducing ID parsing functionality in the msi service and then this would be automatically fixed. |
Well it turns out that our user_assigned_identity resource already implemented the ID Formatters - therefore the root cause of the non-empty diff has been fixed. @allantargino could you please update your PR, resolve the merge conflict and try the test again? |
I renamed |
@ArcturusZhang even after merging
|
@allantargino - the new parser will need to be used in "case insensitive mode" to parse and the pop out the correctly cased id |
Thank you @ArcturusZhang and @katbyte ! Super clear now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @allantargino - this LGTM 👍
This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.58.0"
}
# ... other configuration ... |
…ty (hashicorp#10502) fix hashicorp#10417 This PR adds both CMK (Customer Managed Keys) and user assigned identities to ADF.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
fix #10417
This PR adds both CMK (Customer Managed Keys) and user assigned identities to ADF.