Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_data_lake_gen2_filesystem_resource: do not set/retrieve ACLs when HNS is not Enabled #10470

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Feb 4, 2021

all synapse related test case are failed because of getting acl for storage data lake gen2 resource.

according to https://docs.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-access-control#do-i-have-to-enable-support-for-acls

acl is enabled when Hierarchical Namespace (HNS) feature in storage account is turned ON.

After testing, when Hierarchical Namespace feature is disabled in storage account, the getAcl rest api will report error, which cause all tc in synapse fails

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @njuCZ

Thanks for this PR - taking a look through I've left some comments inline, but if we can fix those up then we should be able to take another look.

Thanks!

@katbyte katbyte added this to the v2.46.1 milestone Feb 5, 2021
@katbyte katbyte changed the title fix tc for synapse azurerm_synapse_*: do not fail when retrieving ACLs that do not exist Feb 5, 2021
@jackofallops
Copy link
Member

Tests passing:
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 👍

@katbyte katbyte merged commit bd22381 into hashicorp:master Feb 5, 2021
@katbyte katbyte changed the title azurerm_synapse_*: do not fail when retrieving ACLs that do not exist azurerm_storage_data_lake_gen2_filesystem_resource: do not set/retrieve ACLs when HNS is not Enabled Feb 5, 2021
katbyte added a commit that referenced this pull request Feb 5, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 2.46.1 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.46.1"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants