-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyvault: optimising the lookup/adding a cache for Key Vaults #10330
Conversation
…eve it's name This avoids calling the `ListKeyVaults` API call by querying the resource list to locate this specific resource by it's identifier and type instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tombuildsstuff - Couple of suggested changes for error messages while we're touching those lines anyway, but otherwise LGTM 👍
azurerm/internal/services/keyvault/key_vault_secret_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/keyvault/key_vault_secret_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/keyvault/key_vault_secret_resource.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve <[email protected]>
Co-authored-by: Steve <[email protected]>
Co-authored-by: Steve <[email protected]>
This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.45.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR supersedes #7794 and #6866 and fixes #6196 by adding a cache for Key Vaults rather than listing these for each resource, which was intended as a short-term hack.
In addition this PR moves all of the Key Vault helpers to the
keyvault/client
package, meaning the locks can be private fields (and potentially reused in future if necessary).Notably this PR switches to looking the Key Vaults up using a filter on the Resources API to identify the Resource Group, meaning we're no longer pulling the entire list of Key Vaults in the subscription (originally necessary since it's not possible to retrieve a Key Vault without it's resource group directly)
Supersedes #7794
Supersedes #6866
Fixes #6196