Deprecated sql_server but no note on top

[ghost]

Could you add a 'this resource is deprecated' on top? because people land on the deprecated resource a lot and like me spend hours searching on what the differences are between sql_server and mssql_server
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/sql_server

[tombuildsstuff]

hi @Dakpan94

Thanks for opening this issue.

This resource isn't strictly deprecated - there's two usage models (sku vs vcores) available in the two different resources, which is why these are separate, however (as I understand it) Microsoft are no longer adding new functionality to the older sku based model, rather recommending folks switch to using the vcores instead - but as far as I understand it this hasn't been officially deprecated at this point in time.

Since this resource isn't strictly deprecated, at this point in time deprecating this resource is likely unnecessary - but I could see an argument for cross-linking between the two resources to better highlight this, something along the lines of:

~> **Note:** The `azurerm_mssql_server` resource provides support for `vcores` and is recommended going forwards - the `azurerm_sql_server` resource (this resource) provides support for the older `sku` based model.

What do you think?

Thanks!

[ghost]

Hi @tombuildsstuff ,

This would be a great addition IMHO and could some time for future developers!

Kind regards :)

[ruandersMSFT]

@tombuildsstuff Here are some thoughts:

• It's a fair statement that both DTU and vCore models are supported Choose between the vCore and DTU purchasing models
• There is one API to create an Azure SQL Database; yet, Terraform still has two separate object implementations (azurerm_sql_server vs. azurerm_mssql_server) and (azurerm_sql_database vs. azurerm_mssql_database).
• As observed in my PR Add storage_account_type to azurerm_mssql_database #10192 in support of azurerm_sql_database - by default database is geo redundant and fails on azure policy #9492 (where Storage Account Type can't be added given the out of date API), you can observe further challenges associated with having two versions of Terraform objects to deploy the same Azure Resources (one object is based on outdated API that isn't evolving).

Rather than this being an issue of "has not been announced as depreciated", I would look at it from the perspective of there should be a (single) Terraform object that is up to date with deploying / configuring the (single) Azure Resource.

The editions (skus) documented in azurerm_sql_database:

Are represented via the skus in the new object / API:

While I understand Terraform can't rush to deprecate the object today (I'm envisioning the need for all the of the Terraform Imports as a result), I highly recommend that these objects provide warning output that they are old objects, no longer maintained, reference out of date APIs (almost 4 years old in this case -- 2017-03-01-preview) and will be deprecated at an undetermined time down the road.

I would also recommend Terraform not split to "two Terraform objects that control the same Azure Resource type" in the future, as this is the primary challenged being faced now, as opposed to awaiting announcement of deprecation from an API version perspective.

[katbyte]

@ruandersMSFT - when we implemented vcore support i believe there wasn't an single API version that supported both at the time, so we needed to have two resources to support both. If that's changed and there is an API that supports both we can add sku support to the new mssql resource (as its using the newer API version) and finally deprecate/remove the old one.

[github-actions]

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.