Remove max_frame_rate default value

[cretueusebiu]

Fixes #695

This is the same as hashicorp/terraform#11340, but even if it was merged there, it's still not merged here.

Changes proposed in this pull request:

• Remove max_frame_rate default value and let AWS set it.

[pabloxio]

I need this! 😩

[bowczarek]

I need that as well :( any ETA for merging the change and releasing nie provider plugin?

Can't believe it haven't been merged since 15th of January :( simple one line, and it was already fixed in the terraform core but not in aws provider plugin.

[thaffenden]

Sorry to bump, but any news on this tiny one?

[aeschright]

Hi folks, I had a look at the AWS docs for this feature and I agree the max_frame_rate default doesn't make sense. In order to move forward, this PR needs to update our own docs and also make sure the tests are passing.

I suspect it would be a good idea for us to send a default frame_rate of auto here since the field is optional and the AWS docs aren't explicit about what happens if it's blank. If anyone wants to look at the test cases on this resource and make sure they are realistic, that would be very helpful. Thanks!

[svanzoest]

This has been a regression for a long time. I'd be great to have this merged. 🚀

[bflad]

Thanks for submitting this, @cretueusebiu. Please note this worked when adding new testing to cover it, however it broke some existing test configurations until Computed: true was added to that attribute's schema, to denote that the value can be configured outside Terraform by the API and that Terraform should ignore that difference.

Previously:

=== CONT  TestAccAWSElasticTranscoderPreset_Video_FrameRate
    TestAccAWSElasticTranscoderPreset_Video_FrameRate: testing.go:684: Step 0 error: errors during apply:

        Error: Error creating Elastic Transcoder Preset: ValidationException: When you specify a value for MaxFrameRate, you must also specify 'FrameRate':'Auto'. Either change the value of FrameRate or remove the MaxFrameRate object, and resubmit the request.

TestAccAWSElasticTranscoderPreset_Full: testing.go:684: Step 0 error: After applying this step and refreshing, the plan was not empty:

        DIFF:

        DESTROY/CREATE: aws_elastictranscoder_preset.test
        ...
        video.0.max_frame_rate:                       "30" => "" (forces new resource)

Output from acceptance testing:

--- PASS: TestAccAWSElasticTranscoderPreset_disappears (6.52s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (8.90s)
--- PASS: TestAccAWSElasticTranscoderPreset_Description (8.95s)
--- PASS: TestAccAWSElasticTranscoderPreset_Video_FrameRate (9.82s)
--- PASS: TestAccAWSElasticTranscoderPreset_Full (15.27s)

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!