3394 redshift node output

[russellsherman]

Fixes #3394.
Relates #20727.

Changes proposed in this pull request:

• Adds cluster node IPs

Current output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRedshiftCluster_privateIps -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_privateIps
FAIL  github.com/terraform-providers/terraform-provider-aws/aws       746.561s
make: *** [testacc] Error 1

Would really love some feedback on this as it's my first PR and not the most familiar with Go. I believe that setting this resource attribute is not possible at creation as the AWS response does not include this information. It's possible to obtain via a describe-cluster --cluster-name {clusterName} command after the cluster has been created though.

Is there an established method of adding this kind of post-creation computed value to a resource elsewhere in this provider I can reference?

[natarajanc]

possible to merge this ?

[michieldhadamus]

Would be great if this could be merged!

[bflad]

Hi @russellsherman 👋 Are you still interested in working on this? If so, I can provide some initial feedback, otherwise please let us know if we can finish this. Thank you.

[russellsherman]

@bflad I'd love to see this through, and any feedback would be helpful.

[wardiablo]

Can we have this merge to master and release out soon?

[evilr00t]

bump, any update on this?

[ewbankkit]

LGTM 🚀.

% ACCTEST_PARALLELISM=10 make testacc TEST=./aws TESTARGS='-run=TestAccAWSRedshiftCluster_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSRedshiftCluster_ -timeout 180m
=== RUN   TestAccAWSRedshiftCluster_basic
=== PAUSE TestAccAWSRedshiftCluster_basic
=== RUN   TestAccAWSRedshiftCluster_withFinalSnapshot
=== PAUSE TestAccAWSRedshiftCluster_withFinalSnapshot
=== RUN   TestAccAWSRedshiftCluster_kmsKey
=== PAUSE TestAccAWSRedshiftCluster_kmsKey
=== RUN   TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
=== PAUSE TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
=== RUN   TestAccAWSRedshiftCluster_loggingEnabled
=== PAUSE TestAccAWSRedshiftCluster_loggingEnabled
=== RUN   TestAccAWSRedshiftCluster_snapshotCopy
=== PAUSE TestAccAWSRedshiftCluster_snapshotCopy
=== RUN   TestAccAWSRedshiftCluster_iamRoles
=== PAUSE TestAccAWSRedshiftCluster_iamRoles
=== RUN   TestAccAWSRedshiftCluster_publiclyAccessible
=== PAUSE TestAccAWSRedshiftCluster_publiclyAccessible
=== RUN   TestAccAWSRedshiftCluster_updateNodeCount
=== PAUSE TestAccAWSRedshiftCluster_updateNodeCount
=== RUN   TestAccAWSRedshiftCluster_updateNodeType
=== PAUSE TestAccAWSRedshiftCluster_updateNodeType
=== RUN   TestAccAWSRedshiftCluster_tags
=== PAUSE TestAccAWSRedshiftCluster_tags
=== RUN   TestAccAWSRedshiftCluster_forceNewUsername
=== PAUSE TestAccAWSRedshiftCluster_forceNewUsername
=== RUN   TestAccAWSRedshiftCluster_changeAvailabilityZone
=== PAUSE TestAccAWSRedshiftCluster_changeAvailabilityZone
=== RUN   TestAccAWSRedshiftCluster_changeEncryption1
=== PAUSE TestAccAWSRedshiftCluster_changeEncryption1
=== RUN   TestAccAWSRedshiftCluster_changeEncryption2
=== PAUSE TestAccAWSRedshiftCluster_changeEncryption2
=== CONT  TestAccAWSRedshiftCluster_basic
=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
=== CONT  TestAccAWSRedshiftCluster_changeEncryption2
=== CONT  TestAccAWSRedshiftCluster_changeEncryption1
=== CONT  TestAccAWSRedshiftCluster_publiclyAccessible
=== CONT  TestAccAWSRedshiftCluster_iamRoles
=== CONT  TestAccAWSRedshiftCluster_changeAvailabilityZone
=== CONT  TestAccAWSRedshiftCluster_loggingEnabled
=== CONT  TestAccAWSRedshiftCluster_forceNewUsername
=== CONT  TestAccAWSRedshiftCluster_snapshotCopy
--- PASS: TestAccAWSRedshiftCluster_basic (816.47s)
=== CONT  TestAccAWSRedshiftCluster_tags
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (841.34s)
=== CONT  TestAccAWSRedshiftCluster_updateNodeType
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (1035.05s)
=== CONT  TestAccAWSRedshiftCluster_kmsKey
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1058.06s)
=== CONT  TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
--- PASS: TestAccAWSRedshiftCluster_tags (545.09s)
=== CONT  TestAccAWSRedshiftCluster_withFinalSnapshot
--- PASS: TestAccAWSRedshiftCluster_iamRoles (1435.67s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1654.82s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (1666.13s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (3640.62s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (3116.47s)
=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
    resource_aws_redshift_cluster_test.go:372: Step 2/2 error: Error running apply: exit status 1
        
        Error: Error Modifying Redshift Cluster (tf-redshift-cluster-6386239506091456576): timeout while waiting for state to become 'available' (last state: 'resizing', timeout: 1h15m0s)
        
          with aws_redshift_cluster.default,
          on terraform_plugin_test.tf line 12, in resource "aws_redshift_cluster" "default":
          12: resource "aws_redshift_cluster" "default" {
        
=== CONT  TestAccAWSRedshiftCluster_kmsKey
    resource_aws_redshift_cluster_test.go:150: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 1h15m0s)
        
          with aws_redshift_cluster.default,
          on terraform_plugin_test.tf line 34, in resource "aws_redshift_cluster" "default":
          34: resource "aws_redshift_cluster" "default" {
        
=== CONT  TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
    resource_aws_redshift_cluster_test.go:186: Step 1/3 error: Error running apply: exit status 1
        
        Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 1h15m0s)
        
          with aws_redshift_cluster.default,
          on terraform_plugin_test.tf line 12, in resource "aws_redshift_cluster" "default":
          12: resource "aws_redshift_cluster" "default" {
        
=== CONT  TestAccAWSRedshiftCluster_forceNewUsername
    resource_aws_redshift_cluster_test.go:484: Step 2/2 error: Error running apply: exit status 1
        
        Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 1h15m0s)
        
          with aws_redshift_cluster.default,
          on terraform_plugin_test.tf line 12, in resource "aws_redshift_cluster" "default":
          12: resource "aws_redshift_cluster" "default" {
        
=== CONT  TestAccAWSRedshiftCluster_withFinalSnapshot
    resource_aws_redshift_cluster_test.go:116: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 1h15m0s)
        
          with aws_redshift_cluster.default,
          on terraform_plugin_test.tf line 12, in resource "aws_redshift_cluster" "default":
          12: resource "aws_redshift_cluster" "default" {
        
=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Redshift Cluster (tf-redshift-cluster-6386239506091456576): InvalidClusterState: Unable to delete the cluster tf-redshift-cluster-6386239506091456576. You can only delete clusters with ACTIVE, INCOMPATIBLE_NETWORK, INCOMPATIBLE_HSM, INCOMPATIBLE_RESTORE, INSUFFICIENT_CAPACITY, or HARDWARE_FAILURE lifecycle.
        	status code: 400, request id: 835907d5-cd54-4cda-93c1-5c8772baa19f
        
--- FAIL: TestAccAWSRedshiftCluster_updateNodeCount (6162.25s)
=== CONT  TestAccAWSRedshiftCluster_kmsKey
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Redshift Cluster (tf-redshift-cluster-3716214157216610256): InvalidClusterState: There is an operation running on the Cluster. Please try to delete it at a later time.
        	status code: 400, request id: cc964296-b7da-4748-a9af-f21d7d06f3b5
        
--- FAIL: TestAccAWSRedshiftCluster_kmsKey (5416.28s)
=== CONT  TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Redshift Cluster (tf-redshift-cluster-1978287369461619161): InvalidClusterState: There is an operation running on the Cluster. Please try to delete it at a later time.
        	status code: 400, request id: 9df93ac9-50df-4811-9a12-0ec0e833c4e8
        
--- FAIL: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (5407.58s)
=== CONT  TestAccAWSRedshiftCluster_forceNewUsername
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Redshift Cluster (tf-redshift-cluster-8343179712699957379): InvalidClusterState: There is an operation running on the Cluster. Please try to delete it at a later time.
        	status code: 400, request id: 6fed3058-75e4-4fde-b84d-807f4a30cc4f
        
--- FAIL: TestAccAWSRedshiftCluster_forceNewUsername (6555.76s)
=== CONT  TestAccAWSRedshiftCluster_withFinalSnapshot
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Redshift Cluster (tf-redshift-cluster-6354952670254163188): InvalidClusterState: There is an operation running on the Cluster. Please try to delete it at a later time.
        	status code: 400, request id: f066c766-dea9-4df8-a490-2857bcbf26e8
        
--- FAIL: TestAccAWSRedshiftCluster_withFinalSnapshot (5407.84s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	6774.708s

Failures are unrelated to this change and are occurring in nightly CI.

[ewbankkit]

@russellsherman Thanks for the contribution 🎉 👏.
In order to get this merged quicker I went ahead and made some changes:

• Instead of a cluster_node_ips list of strings we now have a cluster_nodes list of objects that has node type, private and public IP address fields

[russellsherman]

@ewbankkit Many thanks for this 🙇

[github-actions]

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.