Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 Object support CRC64-NVME checksum algorithm #40964

Open
ewbankkit opened this issue Jan 16, 2025 · 2 comments · May be fixed by #41015
Open

S3 Object support CRC64-NVME checksum algorithm #40964

ewbankkit opened this issue Jan 16, 2025 · 2 comments · May be fixed by #41015
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jan 16, 2025 •
edited
Loading

S3 objects now support the CRC64-NVME checksum algorithm.
Add a checksum_crc64nvme attribute to aws_s3_object (and aws_s3_object_copy).

Requires #40963.
Relates aws/aws-sdk-go-v2#2961.
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title S3 Object support CRC64-NVME checksum algorithm S3 Object support CRC64-NVME checksum algorithm Jan 16, 2025
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. labels Jan 16, 2025
@acwwat acwwat linked a pull request Jan 21, 2025 that will close this issue
Open
@acwwat
Copy link
Contributor

acwwat commented Jan 21, 2025

@ewbankkit I made all the code changes for this enhancement, however the PutObject operation is failing which causes a test case (the most important one) to fail. I believe this is an upstream issue with the AWS SDK.

How should this upstream issue be addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
Milestone
No milestone
2 participants
@ewbankkit @acwwat