Remove unnecessary upper limit on AppRunner Autoscaling Config max size.

[ohookins]

Description

As per #39830, while there is a default maximum autoscaling limit of 25 for AppRunner, it has been possible for some time now to raise the limit with a support request. Indeed, once this limit is raised, you can create an autoscaling config via the API with that arbitrary higher limit. Enforcing a limit in Terraform means we cannot create/update or maintain our actual working autoscaling config that has a higher limit (100 in our case).

There's no advertised actual limit that is possible, so it seems the most practical thing is just to validate the lower limit. At worst, an API error will be returned rather than an error at validation time.

Relations

Closes #39830

References

Output from Acceptance Testing

No tests affect this change.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @ohookins 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppRunnerAutoScalingConfigurationVersion_basic' PKG=apprunner
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerAutoScalingConfigurationVersion_basic -timeout 360m
2024/10/23 09:06:13 Initializing Terraform AWS Provider...
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_basic
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_basic (13.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	18.642s

[ewbankkit]

@ohookins Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!