Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_hub - new resource #39807

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Conversation

DrFaust92
Copy link
Collaborator

Description

Relations

Closes #0000

References

Output from Acceptance Testing

%  make testacc TESTS=TestAccSageMakerHub_  PKG=sagemaker

--- PASS: TestAccSageMakerHub_disappears (14.60s)
--- PASS: TestAccSageMakerHub_s3 (25.29s)
--- PASS: TestAccSageMakerHub_basic (26.01s)
--- PASS: TestAccSageMakerHub_searchKeywords (34.55s)
--- PASS: TestAccSageMakerHub_tags (34.56s)

Signed-off-by: drfaust92 <[email protected]>
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Oct 19, 2024
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 19, 2024
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 marked this pull request as ready for review October 19, 2024 18:39
@DrFaust92 DrFaust92 requested a review from a team as a code owner October 19, 2024 18:39
@ewbankkit ewbankkit self-assigned this Oct 21, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 21, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerHub_' PKG=sagemaker ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 3  -run=TestAccSageMakerHub_ -timeout 360m
2024/10/21 14:58:48 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMakerHub_basic
=== PAUSE TestAccSageMakerHub_basic
=== RUN   TestAccSageMakerHub_searchKeywords
=== PAUSE TestAccSageMakerHub_searchKeywords
=== RUN   TestAccSageMakerHub_s3
=== PAUSE TestAccSageMakerHub_s3
=== RUN   TestAccSageMakerHub_tags
=== PAUSE TestAccSageMakerHub_tags
=== RUN   TestAccSageMakerHub_disappears
=== PAUSE TestAccSageMakerHub_disappears
=== CONT  TestAccSageMakerHub_basic
=== CONT  TestAccSageMakerHub_tags
=== CONT  TestAccSageMakerHub_s3
--- PASS: TestAccSageMakerHub_s3 (18.40s)
=== CONT  TestAccSageMakerHub_searchKeywords
--- PASS: TestAccSageMakerHub_basic (22.57s)
=== CONT  TestAccSageMakerHub_disappears
--- PASS: TestAccSageMakerHub_tags (30.21s)
--- PASS: TestAccSageMakerHub_disappears (10.69s)
--- PASS: TestAccSageMakerHub_searchKeywords (29.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	52.696s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7f7b562 into hashicorp:main Oct 21, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 21, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. service/sagemaker Issues and PRs that pertain to the sagemaker service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants