Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagging tests: Adds tests for ignoring tags #39734

Merged
merged 62 commits into from
Oct 16, 2024
Merged

tagging tests: Adds tests for ignoring tags #39734

merged 62 commits into from
Oct 16, 2024

Conversation

gdavison
Copy link
Contributor

Description

Adds tests for ignored tags when same tag is set on either default tags or resource tags

Adds tests for default tags for data sources

Issue #39733 was detected while creating this PR

@gdavison gdavison requested a review from a team as a code owner October 15, 2024 22:25
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/ec2 Issues and PRs that pertain to the ec2 service. service/s3 Issues and PRs that pertain to the s3 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/sns Issues and PRs that pertain to the sns service. service/rds Issues and PRs that pertain to the rds service. service/sqs Issues and PRs that pertain to the sqs service. service/acm Issues and PRs that pertain to the acm service. service/medialive Issues and PRs that pertain to the medialive service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ssm Issues and PRs that pertain to the ssm service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/kms Issues and PRs that pertain to the kms service. service/batch Issues and PRs that pertain to the batch service. provider Pertains to the provider itself, rather than any interaction with AWS. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/fms Issues and PRs that pertain to the fms service. service/acmpca Issues and PRs that pertain to the acmpca service. service/xray Issues and PRs that pertain to the xray service. service/amplify Issues and PRs that pertain to the amplify service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. labels Oct 15, 2024
@gdavison gdavison force-pushed the td-generate-tagtests-ignore-tags branch from 51d0e99 to 96fbcc9 Compare October 16, 2024 05:40
@ewbankkit ewbankkit self-assigned this Oct 16, 2024
ewbankkit
ewbankkit approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBatchJobDefinitionDataSource_' PKG=batch ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/batch/... -v -count 1 -parallel 3  -run=TestAccBatchJobDefinitionDataSource_ -timeout 360m
2024/10/16 08:15:56 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchJobDefinitionDataSource_tags
=== PAUSE TestAccBatchJobDefinitionDataSource_tags
=== RUN   TestAccBatchJobDefinitionDataSource_tags_NullMap
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_NullMap
=== RUN   TestAccBatchJobDefinitionDataSource_tags_EmptyMap
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_EmptyMap
=== RUN   TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccBatchJobDefinitionDataSource_basicName
=== PAUSE TestAccBatchJobDefinitionDataSource_basicName
=== RUN   TestAccBatchJobDefinitionDataSource_basicARN
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN
=== RUN   TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== RUN   TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
=== PAUSE TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
=== CONT  TestAccBatchJobDefinitionDataSource_tags
=== CONT  TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties
=== CONT  TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobDefinitionDataSource_tags (10.82s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_NodeProperties (11.22s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_ResourceTag (11.68s)
=== CONT  TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties
--- PASS: TestAccBatchJobDefinitionDataSource_tags_DefaultTags_nonOverlapping (10.16s)
=== CONT  TestAccBatchJobDefinitionDataSource_basicARN
--- PASS: TestAccBatchJobDefinitionDataSource_tags_IgnoreTags_Overlap_DefaultTag (10.13s)
=== CONT  TestAccBatchJobDefinitionDataSource_basicName
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN_EKSProperties (10.44s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_EmptyMap
--- PASS: TestAccBatchJobDefinitionDataSource_tags_EmptyMap (9.79s)
=== CONT  TestAccBatchJobDefinitionDataSource_tags_NullMap
--- PASS: TestAccBatchJobDefinitionDataSource_basicARN (17.85s)
--- PASS: TestAccBatchJobDefinitionDataSource_basicName (17.47s)
--- PASS: TestAccBatchJobDefinitionDataSource_tags_NullMap (9.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	47.098s

@gdavison gdavison merged commit 98ea5f1 into main Oct 16, 2024
48 checks passed
@gdavison gdavison deleted the td-generate-tagtests-ignore-tags branch October 16, 2024 16:23
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 16, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 16, 2024
Update CHANGELOG.md for #39734
4db9087
@johnsonaj johnsonaj modified the milestones: v5.73.0, v5.72.1 Oct 16, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.72.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 16, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appfabric Issues and PRs that pertain to the appfabric service. service/appflow Issues and PRs that pertain to the appflow service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apprunner Issues and PRs that pertain to the apprunner service. service/batch Issues and PRs that pertain to the batch service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/drs Issues and PRs that pertain to the drs service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/fms Issues and PRs that pertain to the fms service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/logs Issues and PRs that pertain to the logs service. service/m2 Issues and PRs that pertain to the m2 service. service/medialive Issues and PRs that pertain to the medialive service. service/networkmonitor Issues and PRs that pertain to the networkmonitor service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. service/ssm Issues and PRs that pertain to the ssm service. service/timestreaminfluxdb Issues and PRs that pertain to the timestreaminfluxdb service. service/vpc Issues and PRs that pertain to the vpc service. service/xray Issues and PRs that pertain to the xray service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.72.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @ewbankkit @johnsonaj