Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appconfig extension role arn optional #38900

Conversation

gagan-bhullar-tech
Copy link
Contributor

@gagan-bhullar-tech gagan-bhullar-tech commented Aug 16, 2024

Description

This PR makes role_arn optional in App config extension action point.

Relations

Closes #38709

@gagan-bhullar-tech gagan-bhullar-tech requested a review from a team as a code owner August 16, 2024 18:39
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/appconfig Issues and PRs that pertain to the appconfig service. needs-triage Waiting for first response or review from a maintainer. labels Aug 16, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @gagan-bhullar-tech 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 19, 2024
@nam054 nam054 self-assigned this Aug 30, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 30, 2024
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

> make testacc TESTARGS='-run=TestAccAppConfigExtension_' PKG=appconfig
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/appconfig/... -v -count 1 -parallel 20  -run=TestAccAppConfigExtension_ -timeout 360m
=== RUN   TestAccAppConfigExtension_tags
=== PAUSE TestAccAppConfigExtension_tags
=== RUN   TestAccAppConfigExtension_tags_null
=== PAUSE TestAccAppConfigExtension_tags_null
=== RUN   TestAccAppConfigExtension_tags_AddOnUpdate
=== PAUSE TestAccAppConfigExtension_tags_AddOnUpdate
=== RUN   TestAccAppConfigExtension_tags_EmptyTag_OnCreate
=== PAUSE TestAccAppConfigExtension_tags_EmptyTag_OnCreate
=== RUN   TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_providerOnly
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_providerOnly
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_nonOverlapping
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_overlapping
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_overlapping
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccAppConfigExtension_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccAppConfigExtension_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccAppConfigExtension_tags_ComputedTag_OnCreate
=== PAUSE TestAccAppConfigExtension_tags_ComputedTag_OnCreate
=== RUN   TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccAppConfigExtension_basic
=== PAUSE TestAccAppConfigExtension_basic
=== RUN   TestAccAppConfigExtension_ActionPoint
=== PAUSE TestAccAppConfigExtension_ActionPoint
=== RUN   TestAccAppConfigExtension_Parameter
=== PAUSE TestAccAppConfigExtension_Parameter
=== RUN   TestAccAppConfigExtension_Name
=== PAUSE TestAccAppConfigExtension_Name
=== RUN   TestAccAppConfigExtension_Description
=== PAUSE TestAccAppConfigExtension_Description
=== RUN   TestAccAppConfigExtension_disappears
=== PAUSE TestAccAppConfigExtension_disappears
=== CONT  TestAccAppConfigExtension_tags
=== CONT  TestAccAppConfigExtension_Parameter
=== CONT  TestAccAppConfigExtension_Name
=== CONT  TestAccAppConfigExtension_tags_EmptyTag_OnCreate
=== CONT  TestAccAppConfigExtension_basic
=== CONT  TestAccAppConfigExtension_tags_ComputedTag_OnCreate
=== CONT  TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_overlapping
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccAppConfigExtension_Description
=== CONT  TestAccAppConfigExtension_tags_AddOnUpdate
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_nonOverlapping
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccAppConfigExtension_ActionPoint
=== CONT  TestAccAppConfigExtension_tags_null
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccAppConfigExtension_disappears
--- PASS: TestAccAppConfigExtension_disappears (51.84s)
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_providerOnly
--- PASS: TestAccAppConfigExtension_basic (54.56s)
=== CONT  TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_nullNonOverlappingResourceTag (63.84s)
=== CONT  TestAccAppConfigExtension_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccAppConfigExtension_tags_ComputedTag_OnCreate (63.88s)
=== CONT  TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_nullOverlappingResourceTag (63.98s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_emptyProviderOnlyTag (64.37s)
--- PASS: TestAccAppConfigExtension_tags_null (79.87s)
--- PASS: TestAccAppConfigExtension_Description (87.17s)
--- PASS: TestAccAppConfigExtension_Name (90.35s)
--- PASS: TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Replace (96.89s)
--- PASS: TestAccAppConfigExtension_tags_AddOnUpdate (97.65s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_updateToResourceOnly (98.04s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_updateToProviderOnly (98.73s)
--- PASS: TestAccAppConfigExtension_tags_EmptyTag_OnCreate (103.06s)
--- PASS: TestAccAppConfigExtension_Parameter (108.04s)
--- PASS: TestAccAppConfigExtension_ActionPoint (108.41s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_emptyResourceTag (45.51s)
--- PASS: TestAccAppConfigExtension_tags_EmptyTag_OnUpdate_Add (117.06s)
--- PASS: TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Replace (67.84s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_overlapping (123.86s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_nonOverlapping (124.33s)
--- PASS: TestAccAppConfigExtension_tags_ComputedTag_OnUpdate_Add (61.76s)
--- PASS: TestAccAppConfigExtension_tags (135.05s)
--- PASS: TestAccAppConfigExtension_tags_DefaultTags_providerOnly (103.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  159.727s

@nam054 nam054 merged commit 6efc447 into hashicorp:main Aug 31, 2024
37 checks passed
@nam054
Copy link
Contributor

nam054 commented Aug 31, 2024

@gagan-bhullar-tech Thank you for your contribution!!

@github-actions github-actions bot added this to the v5.66.0 milestone Aug 31, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Oct 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appconfig Issues and PRs that pertain to the appconfig service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_appconfig_extension action_point.role_arn shouldn't be required
3 participants