Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lexmodelsv2(test): handle PreconditionFailedException on delete #38661

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 2, 2024

Description

Fixes _disappears tests for the bot, bot locale, and bot version resources which were not handling PreconditionFailedException errors.

Before:

% make testacc PKG=lexv2models TESTS="TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears'  -timeout 360m

    bot_test.go:124: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot ("5FUXN7KX75"): operation error Lex Models V2: DeleteBot, https response error StatusCode: 412, RequestID: 91556c02-7ceb-4af4-81a8-c3480eede6d1, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBot, https response error StatusCode:
        412, RequestID: 91556c02-7ceb-4af4-81a8-c3480eede6d1,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBot_disappears (16.42s)
=== NAME  TestAccLexV2ModelsBotLocale_disappears
    bot_locale_test.go:69: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot Locale ("en_US"): operation error Lex Models V2: DeleteBotLocale, https response error StatusCode: 412, RequestID: 7aca0765-3185-491b-8196-a0047c3aac3f, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBotLocale, https response error
        StatusCode: 412, RequestID: 7aca0765-3185-491b-8196-a0047c3aac3f,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBotLocale_disappears (26.23s)
=== NAME  TestAccLexV2ModelsBotVersion_disappears
    bot_version_test.go:69: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot Version ("R8R6LBARQ7,1"): operation error Lex Models V2: DeleteBotVersion, https response error StatusCode: 412, RequestID: 2389c15b-6fa0-4793-9694-1f9553f93953, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBotVersion, https response error
        StatusCode: 412, RequestID: 2389c15b-6fa0-4793-9694-1f9553f93953,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBotVersion_disappears (34.46s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        40.510s

After:

% make testacc PKG=lexv2models TESTS="TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears'  -timeout 360m

--- PASS: TestAccLexV2ModelsBot_disappears (26.59s)
--- PASS: TestAccLexV2ModelsBotLocale_disappears (41.12s)
--- PASS: TestAccLexV2ModelsBotVersion_disappears (49.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        56.721s

Copy link

github-actions bot commented Aug 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/lexv2models Issues and PRs that pertain to the lexv2models service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 2, 2024
Fixes `_disappears` tests for the bot, bot locale, and bot version resources which were not handling `PreconditionFailedException` errors.

Before:

```console
% make testacc PKG=lexv2models TESTS="TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears'  -timeout 360m

    bot_test.go:124: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot ("5FUXN7KX75"): operation error Lex Models V2: DeleteBot, https response error StatusCode: 412, RequestID: 91556c02-7ceb-4af4-81a8-c3480eede6d1, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBot, https response error StatusCode:
        412, RequestID: 91556c02-7ceb-4af4-81a8-c3480eede6d1,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBot_disappears (16.42s)
=== NAME  TestAccLexV2ModelsBotLocale_disappears
    bot_locale_test.go:69: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot Locale ("en_US"): operation error Lex Models V2: DeleteBotLocale, https response error StatusCode: 412, RequestID: 7aca0765-3185-491b-8196-a0047c3aac3f, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBotLocale, https response error
        StatusCode: 412, RequestID: 7aca0765-3185-491b-8196-a0047c3aac3f,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBotLocale_disappears (26.23s)
=== NAME  TestAccLexV2ModelsBotVersion_disappears
    bot_version_test.go:69: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting AWS Lex V2 Models Bot Version ("R8R6LBARQ7,1"): operation error Lex Models V2: DeleteBotVersion, https response error StatusCode: 412, RequestID: 2389c15b-6fa0-4793-9694-1f9553f93953, PreconditionFailedException: Failed to retrieve resource since it does not exist

        operation error Lex Models V2: DeleteBotVersion, https response error
        StatusCode: 412, RequestID: 2389c15b-6fa0-4793-9694-1f9553f93953,
        PreconditionFailedException: Failed to retrieve resource since it does not
        exist
--- FAIL: TestAccLexV2ModelsBotVersion_disappears (34.46s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        40.510s

```

After:

```console
% make testacc PKG=lexv2models TESTS="TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBot_disappears|TestAccLexV2ModelsBotLocale_disappears|TestAccLexV2ModelsBotVersion_disappears'  -timeout 360m

--- PASS: TestAccLexV2ModelsBot_disappears (26.59s)
--- PASS: TestAccLexV2ModelsBotLocale_disappears (41.12s)
--- PASS: TestAccLexV2ModelsBotVersion_disappears (49.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        56.721s
```
@jar-b jar-b force-pushed the td-lexv2models-disappears branch from 6efa46d to 5de07ad Compare August 2, 2024 15:36
@jar-b jar-b marked this pull request as ready for review August 2, 2024 17:14
@jar-b jar-b requested a review from a team as a code owner August 2, 2024 17:14
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit d54d2ae into main Aug 5, 2024
38 checks passed
@jar-b jar-b deleted the td-lexv2models-disappears branch August 5, 2024 14:46
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 5, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/lexv2models Issues and PRs that pertain to the lexv2models service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants