Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: The example does not correspond recomendation from AWS. Use ~all instaead of -all #38242

Open
EugenKon opened this issue Jul 3, 2024 · 6 comments
Labels
documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service.

Comments

@EugenKon
Copy link

EugenKon commented Jul 3, 2024

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ses_domain_mail_from#domain-identity-mail-from

Description

The information from Terraform:
image

The infromation from AWS
https://docs.aws.amazon.com/ses/latest/dg/mail-from.html#mail-from-set
image

Also in your examples you use aws_route53_zone.example.id, but this resource does not have such argument/attribute. zone_id must be used instead https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route53_zone#zone_id

  1. I suppose here is also error:
    https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ses_domain_identity_verification#example-usage
    image

id != domain_name

References

No response

Would you like to implement a fix?

None

@EugenKon EugenKon added the documentation Introduces or discusses updates to documentation. label Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 3, 2024
@emiljoshva
Copy link

I like to work on this issue

@emiljoshva
Copy link

emiljoshva commented Jul 4, 2024

@EugenKon as per https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ses_domain_identity_verification#id

This resource exports the following attributes in addition to the arguments above:
id - The domain name of the domain identity.

aws_route53_zone.example.id - seems to be correct.

@EugenKon
Copy link
Author

EugenKon commented Jul 4, 2024

Are 'id' and 'domain' have the same value?

@emiljoshva
Copy link

emiljoshva commented Jul 4, 2024

@EugenKon yes they both represent same
While the id might be set to the same value as the domain for the aws_ses_domain_identity_verification resource, they serve different purposes.
The domain is an input argument that you provide to specify the domain you're verifying, while the id is an automatically assigned identifier used by Terraform to track the resource.

@EugenKon
Copy link
Author

EugenKon commented Jul 4, 2024

In my understanding, then we should use 'domain'.

@justinretzolk justinretzolk added service/ses Issues and PRs that pertain to the ses service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
Development

No branches or pull requests

3 participants