-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add execution_mode arg to aws_codepipeline #35875
feat: Add execution_mode arg to aws_codepipeline #35875
Conversation
Community NoteVoting for Prioritization
For Submitters
|
e600efc
to
354c1c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodePipeline_' PKG=codepipeline ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 3 -run=TestAccCodePipeline_ -timeout 360m
=== RUN TestAccCodePipeline_basic
=== PAUSE TestAccCodePipeline_basic
=== RUN TestAccCodePipeline_disappears
=== PAUSE TestAccCodePipeline_disappears
=== RUN TestAccCodePipeline_emptyStageArtifacts
=== PAUSE TestAccCodePipeline_emptyStageArtifacts
=== RUN TestAccCodePipeline_deployWithServiceRole
=== PAUSE TestAccCodePipeline_deployWithServiceRole
=== RUN TestAccCodePipeline_tags
=== PAUSE TestAccCodePipeline_tags
=== RUN TestAccCodePipeline_MultiRegion_basic
=== PAUSE TestAccCodePipeline_MultiRegion_basic
=== RUN TestAccCodePipeline_MultiRegion_update
=== PAUSE TestAccCodePipeline_MultiRegion_update
=== RUN TestAccCodePipeline_MultiRegion_convertSingleRegion
=== PAUSE TestAccCodePipeline_MultiRegion_convertSingleRegion
=== RUN TestAccCodePipeline_withNamespace
=== PAUSE TestAccCodePipeline_withNamespace
=== RUN TestAccCodePipeline_withGitHubV1SourceAction
acctest.go:2482: Environment variable GITHUB_TOKEN is not set, skipping test
--- SKIP: TestAccCodePipeline_withGitHubV1SourceAction (0.00s)
=== RUN TestAccCodePipeline_ecr
=== PAUSE TestAccCodePipeline_ecr
=== RUN TestAccCodePipeline_pipelinetype
=== PAUSE TestAccCodePipeline_pipelinetype
=== CONT TestAccCodePipeline_basic
=== CONT TestAccCodePipeline_MultiRegion_update
=== CONT TestAccCodePipeline_ecr
--- PASS: TestAccCodePipeline_ecr (39.73s)
=== CONT TestAccCodePipeline_pipelinetype
--- PASS: TestAccCodePipeline_basic (64.83s)
=== CONT TestAccCodePipeline_deployWithServiceRole
--- PASS: TestAccCodePipeline_MultiRegion_update (70.16s)
=== CONT TestAccCodePipeline_MultiRegion_basic
--- PASS: TestAccCodePipeline_deployWithServiceRole (35.85s)
=== CONT TestAccCodePipeline_tags
--- PASS: TestAccCodePipeline_MultiRegion_basic (45.51s)
=== CONT TestAccCodePipeline_MultiRegion_convertSingleRegion
--- PASS: TestAccCodePipeline_pipelinetype (80.28s)
=== CONT TestAccCodePipeline_emptyStageArtifacts
--- PASS: TestAccCodePipeline_emptyStageArtifacts (32.99s)
=== CONT TestAccCodePipeline_disappears
--- PASS: TestAccCodePipeline_tags (74.16s)
=== CONT TestAccCodePipeline_withNamespace
--- PASS: TestAccCodePipeline_disappears (31.77s)
--- PASS: TestAccCodePipeline_MultiRegion_convertSingleRegion (88.06s)
--- PASS: TestAccCodePipeline_withNamespace (33.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline 219.810s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds a new argument called
execution_mode
to theaws_codepipeline
resource to support additional execution mode for V2 pipelines per https://aws.amazon.com/about-aws/whats-new/2024/02/codepipeline-trigger-filters-execution-modes/.Relations
Closes #35810
References
Referred to the AWS API reference for specs of the new argument.
Output from Acceptance Testing
Note that
TestAccCodePipeline_pipelinetype
was enhanced to validate the newexecution_mode
argument.Separately, there is a failure in the
TestAccCodePipeline_MultiRegion_convertSingleRegion
test case which is unrelated. I will try to see if I can fix it, but it's not caused by this PR's changes.Updated: It looks like the test case is failing because the
region
attribute forartifact_store
hasComputed
set when it probably shouldn't have. Removing it seems to fix the test case, and I've also added region checks toTestAccCodePipeline_MultiRegion_convertSingleRegion
. Here are the updated results: