Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #35491 #35501

Merged
merged 5 commits into from
Jan 31, 2024
Merged

fix #35491 #35501

merged 5 commits into from
Jan 31, 2024

Conversation

frediana
Copy link
Contributor

@frediana frediana commented Jan 26, 2024

Description

FIx issue when import cognito user group contains "/".

Relations

Closes #35491

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Jan 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 26, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 26, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPUserGroup_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPUserGroup_ -timeout 360m
=== RUN   TestAccCognitoIDPUserGroup_basic
=== PAUSE TestAccCognitoIDPUserGroup_basic
=== RUN   TestAccCognitoIDPUserGroup_disappears
=== PAUSE TestAccCognitoIDPUserGroup_disappears
=== RUN   TestAccCognitoIDPUserGroup_complex
=== PAUSE TestAccCognitoIDPUserGroup_complex
=== RUN   TestAccCognitoIDPUserGroup_roleARN
=== PAUSE TestAccCognitoIDPUserGroup_roleARN
=== CONT  TestAccCognitoIDPUserGroup_basic
=== CONT  TestAccCognitoIDPUserGroup_complex
--- PASS: TestAccCognitoIDPUserGroup_basic (38.31s)
=== CONT  TestAccCognitoIDPUserGroup_disappears
--- PASS: TestAccCognitoIDPUserGroup_complex (38.38s)
=== CONT  TestAccCognitoIDPUserGroup_roleARN
--- PASS: TestAccCognitoIDPUserGroup_disappears (19.05s)
--- PASS: TestAccCognitoIDPUserGroup_roleARN (34.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	83.909s

@ewbankkit
Copy link
Contributor

@frediana Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 022d636 into hashicorp:main Jan 31, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 31, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cognito_user_group import groups with '/'
3 participants