r/aws_lakeformation_resource: add use_service_linked_role argument

[jar-b]

Description

This argument will allow pracitioners to explicitly configure whether the value of UseServiceLinkedRole boolean in the underlying AWS RegisterResource API. Also fixes a bug where deleted resource registrations were not handled correctly by the destroy operation.

Relations

Closes #35283

References

• https://docs.aws.amazon.com/lake-formation/latest/APIReference/API_RegisterResource.html

Output from Acceptance Testing

% make testacc PKG=lakeformation TESTS=TestAccLakeFormationResource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormationResource_'  -timeout 360m

--- PASS: TestAccLakeFormationResource_basic (15.66s)
--- PASS: TestAccLakeFormationResource_disappears (16.16s)
--- PASS: TestAccLakeFormationResource_serviceLinkedRole (16.32s)
--- PASS: TestAccLakeFormationResource_updateRoleToRole (26.47s)
--- PASS: TestAccLakeFormationResource_updateSLRToRole (27.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      31.253s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLakeFormationResource_' PKG=lakeformation ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 3  -run=TestAccLakeFormationResource_ -timeout 360m
=== RUN   TestAccLakeFormationResource_basic
=== PAUSE TestAccLakeFormationResource_basic
=== RUN   TestAccLakeFormationResource_disappears
=== PAUSE TestAccLakeFormationResource_disappears
=== RUN   TestAccLakeFormationResource_serviceLinkedRole
=== PAUSE TestAccLakeFormationResource_serviceLinkedRole
=== RUN   TestAccLakeFormationResource_updateRoleToRole
=== PAUSE TestAccLakeFormationResource_updateRoleToRole
=== RUN   TestAccLakeFormationResource_updateSLRToRole
=== PAUSE TestAccLakeFormationResource_updateSLRToRole
=== CONT  TestAccLakeFormationResource_basic
=== CONT  TestAccLakeFormationResource_updateRoleToRole
=== CONT  TestAccLakeFormationResource_updateSLRToRole
--- PASS: TestAccLakeFormationResource_basic (23.64s)
=== CONT  TestAccLakeFormationResource_disappears
--- PASS: TestAccLakeFormationResource_updateRoleToRole (40.83s)
=== CONT  TestAccLakeFormationResource_serviceLinkedRole
--- PASS: TestAccLakeFormationResource_updateSLRToRole (41.20s)
--- PASS: TestAccLakeFormationResource_disappears (22.08s)
--- PASS: TestAccLakeFormationResource_serviceLinkedRole (20.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	69.840s

[github-actions]

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.