resource/aws_ami: Fixes eventual consistency errors

[gdavison]

Description

The parameters description and deprecation_time are set or modified using eventually consistent operations. This was causing them to not be updated in Terraform state.

Also affects aws_ami_from_instance and aws_ami_copy

Output from Acceptance Testing

% make testacc PKG=ec2 TESTS='TestAccEC2AMI_|TestAccEC2AMICopy_|TestAccEC2AMIFromInstance_'

--- PASS: TestAccEC2AMI_ephemeralBlockDevices (1049.53s)
--- PASS: TestAccEC2AMI_gp3BlockDevice (1058.41s)
--- PASS: TestAccEC2AMI_imdsSupport (1066.79s)
--- PASS: TestAccEC2AMI_tpmSupport (1071.75s)
--- PASS: TestAccEC2AMI_disappears (1074.21s)
--- PASS: TestAccEC2AMI_boot (1075.10s)
--- PASS: TestAccEC2AMI_basic (1086.15s)
--- PASS: TestAccEC2AMIFromInstance_basic (1140.95s)
--- PASS: TestAccEC2AMIFromInstance_disappears (1155.93s)
--- PASS: TestAccEC2AMICopy_basic (1173.47s)
--- PASS: TestAccEC2AMICopy_enaSupport (1175.05s)
--- PASS: TestAccEC2AMI_description (1243.46s)
--- PASS: TestAccEC2AMI_tags (1359.69s)
--- PASS: TestAccEC2AMICopy_description (1366.41s)
--- PASS: TestAccEC2AMI_deprecateAt (1378.52s)
--- PASS: TestAccEC2AMIFromInstance_tags (1396.37s)
--- PASS: TestAccEC2AMICopy_tags (1473.40s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

[ewbankkit]

Do we need to additionally mention aws_ami_from_instance and aws_ami_copy?

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2AMI_\|TestAccEC2AMICopy_\|TestAccEC2AMIFromInstance_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2AMI_\|TestAccEC2AMICopy_\|TestAccEC2AMIFromInstance_ -timeout 360m
=== RUN   TestAccEC2AMICopy_basic
=== PAUSE TestAccEC2AMICopy_basic
=== RUN   TestAccEC2AMICopy_description
=== PAUSE TestAccEC2AMICopy_description
=== RUN   TestAccEC2AMICopy_enaSupport
=== PAUSE TestAccEC2AMICopy_enaSupport
=== RUN   TestAccEC2AMICopy_destinationOutpost
=== PAUSE TestAccEC2AMICopy_destinationOutpost
=== RUN   TestAccEC2AMICopy_tags
=== PAUSE TestAccEC2AMICopy_tags
=== RUN   TestAccEC2AMIFromInstance_basic
=== PAUSE TestAccEC2AMIFromInstance_basic
=== RUN   TestAccEC2AMIFromInstance_tags
=== PAUSE TestAccEC2AMIFromInstance_tags
=== RUN   TestAccEC2AMIFromInstance_disappears
=== PAUSE TestAccEC2AMIFromInstance_disappears
=== RUN   TestAccEC2AMI_basic
=== PAUSE TestAccEC2AMI_basic
=== RUN   TestAccEC2AMI_deprecateAt
=== PAUSE TestAccEC2AMI_deprecateAt
=== RUN   TestAccEC2AMI_description
=== PAUSE TestAccEC2AMI_description
=== RUN   TestAccEC2AMI_disappears
=== PAUSE TestAccEC2AMI_disappears
=== RUN   TestAccEC2AMI_ephemeralBlockDevices
=== PAUSE TestAccEC2AMI_ephemeralBlockDevices
=== RUN   TestAccEC2AMI_gp3BlockDevice
=== PAUSE TestAccEC2AMI_gp3BlockDevice
=== RUN   TestAccEC2AMI_tags
=== PAUSE TestAccEC2AMI_tags
=== RUN   TestAccEC2AMI_outpost
=== PAUSE TestAccEC2AMI_outpost
=== RUN   TestAccEC2AMI_boot
=== PAUSE TestAccEC2AMI_boot
=== RUN   TestAccEC2AMI_tpmSupport
=== PAUSE TestAccEC2AMI_tpmSupport
=== RUN   TestAccEC2AMI_imdsSupport
=== PAUSE TestAccEC2AMI_imdsSupport
=== CONT  TestAccEC2AMICopy_basic
=== CONT  TestAccEC2AMI_description
--- PASS: TestAccEC2AMI_description (103.25s)
=== CONT  TestAccEC2AMI_outpost
    acctest.go:1157: skipping since no Outposts found
--- SKIP: TestAccEC2AMI_outpost (0.47s)
=== CONT  TestAccEC2AMI_imdsSupport
--- PASS: TestAccEC2AMICopy_basic (142.25s)
=== CONT  TestAccEC2AMI_tpmSupport
--- PASS: TestAccEC2AMI_imdsSupport (73.01s)
=== CONT  TestAccEC2AMI_boot
--- PASS: TestAccEC2AMI_tpmSupport (73.45s)
=== CONT  TestAccEC2AMIFromInstance_basic
--- PASS: TestAccEC2AMI_boot (72.21s)
=== CONT  TestAccEC2AMI_deprecateAt
--- PASS: TestAccEC2AMI_deprecateAt (135.52s)
=== CONT  TestAccEC2AMI_basic
--- PASS: TestAccEC2AMI_basic (74.06s)
=== CONT  TestAccEC2AMICopy_destinationOutpost
    acctest.go:1157: skipping since no Outposts found
--- SKIP: TestAccEC2AMICopy_destinationOutpost (0.49s)
=== CONT  TestAccEC2AMICopy_tags
--- PASS: TestAccEC2AMIFromInstance_basic (310.44s)
=== CONT  TestAccEC2AMIFromInstance_disappears
--- PASS: TestAccEC2AMICopy_tags (188.54s)
=== CONT  TestAccEC2AMIFromInstance_tags
--- PASS: TestAccEC2AMIFromInstance_disappears (319.38s)
=== CONT  TestAccEC2AMI_gp3BlockDevice
--- PASS: TestAccEC2AMI_gp3BlockDevice (74.24s)
=== CONT  TestAccEC2AMICopy_enaSupport
--- PASS: TestAccEC2AMICopy_enaSupport (142.82s)
=== CONT  TestAccEC2AMI_tags
--- PASS: TestAccEC2AMIFromInstance_tags (421.09s)
=== CONT  TestAccEC2AMI_ephemeralBlockDevices
--- PASS: TestAccEC2AMI_ephemeralBlockDevices (76.03s)
=== CONT  TestAccEC2AMICopy_description
--- PASS: TestAccEC2AMI_tags (117.44s)
=== CONT  TestAccEC2AMI_disappears
--- PASS: TestAccEC2AMI_disappears (70.23s)
--- PASS: TestAccEC2AMICopy_description (165.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1316.129s

[github-actions]

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.