Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudformation_stack: Set computed fields correctly #33969

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Oct 17, 2023

Description

Relations

Closes #33327

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccCloudFormationStack_' PKG=cloudformation

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20  -run=TestAccCloudFormationStack_ -timeout 360m
--- PASS: TestAccCloudFormationStack_disappears (122.15s)
--- PASS: TestAccCloudFormationStack_yaml (143.68s)
--- PASS: TestAccCloudFormationStack_onFailure (160.02s)
--- PASS: TestAccCloudFormationStack_withTransform (162.62s)
--- PASS: TestAccCloudFormationStack_basic (168.87s)
--- PASS: TestAccCloudFormationStack_updateFailure (171.24s)
--- PASS: TestAccCloudFormationStack_defaultParams (188.29s)
--- PASS: TestAccCloudFormationStack_withParams (209.04s)
--- PASS: TestAccCloudFormationStack_CreationFailure_doNothing (210.11s)
--- PASS: TestAccCloudFormationStack_CreationFailure_delete (212.13s)
--- PASS: TestAccCloudFormationStack_templateUpdate (221.74s)
--- PASS: TestAccCloudFormationStack_outputsUpdated (221.77s)
--- PASS: TestAccCloudFormationStack_CreationFailure_rollback (221.80s)
--- PASS: TestAccCloudFormationStack_allAttributes (271.92s)
--- PASS: TestAccCloudFormationStack_WithURLWithParams_withYAML (383.11s)
--- PASS: TestAccCloudFormationStack_WithURLWithParams_noUpdate (545.84s)
--- PASS: TestAccCloudFormationStack_WithURL_withParams (568.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	571.454s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/cloudformation Issues and PRs that pertain to the cloudformation service. labels Oct 17, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 17, 2023
@johnsonaj johnsonaj added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 17, 2023
@johnsonaj johnsonaj merged commit 9857b58 into main Oct 17, 2023
32 checks passed
@johnsonaj johnsonaj deleted the b-cloudformation_stack_computed branch October 17, 2023 17:08
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 17, 2023
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Oct 20, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_cloudformation_stack outputs disappear when using sensitive parameters
2 participants