Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_pipes_pipe: Prevent ValidationException errors on Update #32622

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 20, 2023

Description

Only send enrichment_parameters, source_parameters and target_parameters to the Update API if their values have changed.

Relations

Closes #32423.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccPipesPipe_' PKG=pipes ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pipes/... -v -count 1 -parallel 2  -run=TestAccPipesPipe_ -timeout 180m
=== RUN   TestAccPipesPipe_basicSQS
=== PAUSE TestAccPipesPipe_basicSQS
=== RUN   TestAccPipesPipe_disappears
=== PAUSE TestAccPipesPipe_disappears
=== RUN   TestAccPipesPipe_description
=== PAUSE TestAccPipesPipe_description
=== RUN   TestAccPipesPipe_desiredState
=== PAUSE TestAccPipesPipe_desiredState
=== RUN   TestAccPipesPipe_enrichment
=== PAUSE TestAccPipesPipe_enrichment
=== RUN   TestAccPipesPipe_enrichmentParameters
=== PAUSE TestAccPipesPipe_enrichmentParameters
=== RUN   TestAccPipesPipe_sourceParameters_filterCriteria
=== PAUSE TestAccPipesPipe_sourceParameters_filterCriteria
=== RUN   TestAccPipesPipe_nameGenerated
=== PAUSE TestAccPipesPipe_nameGenerated
=== RUN   TestAccPipesPipe_namePrefix
=== PAUSE TestAccPipesPipe_namePrefix
=== RUN   TestAccPipesPipe_roleARN
=== PAUSE TestAccPipesPipe_roleARN
=== RUN   TestAccPipesPipe_tags
=== PAUSE TestAccPipesPipe_tags
=== RUN   TestAccPipesPipe_targetUpdate
=== PAUSE TestAccPipesPipe_targetUpdate
=== RUN   TestAccPipesPipe_targetParameters_inputTemplate
=== PAUSE TestAccPipesPipe_targetParameters_inputTemplate
=== RUN   TestAccPipesPipe_kinesisSourceAndTarget
=== PAUSE TestAccPipesPipe_kinesisSourceAndTarget
=== RUN   TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== PAUSE TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== RUN   TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== PAUSE TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== RUN   TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== PAUSE TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== RUN   TestAccPipesPipe_mskSourceHTTPTarget
    acctest.go:82: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_mskSourceHTTPTarget (0.00s)
=== RUN   TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget
    acctest.go:82: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget (0.00s)
=== RUN   TestAccPipesPipe_sqsSourceRedshiftTarget
=== PAUSE TestAccPipesPipe_sqsSourceRedshiftTarget
=== RUN   TestAccPipesPipe_SourceSageMakerTarget
    acctest.go:82: aws_sagemaker_pipeline resource not yet implemented
--- SKIP: TestAccPipesPipe_SourceSageMakerTarget (0.00s)
=== RUN   TestAccPipesPipe_sqsSourceBatchJobTarget
=== PAUSE TestAccPipesPipe_sqsSourceBatchJobTarget
=== RUN   TestAccPipesPipe_sqsSourceECSTaskTarget
    acctest.go:82: ValidationException: [numeric instance is lower than the required minimum (minimum: 1, found: 0)]
--- SKIP: TestAccPipesPipe_sqsSourceECSTaskTarget (0.00s)
=== CONT  TestAccPipesPipe_basicSQS
=== CONT  TestAccPipesPipe_sqsSourceBatchJobTarget
--- PASS: TestAccPipesPipe_basicSQS (116.89s)
=== CONT  TestAccPipesPipe_sqsSourceRedshiftTarget
--- PASS: TestAccPipesPipe_sqsSourceBatchJobTarget (193.23s)
=== CONT  TestAccPipesPipe_rabbitMQSourceEventBusTarget
--- PASS: TestAccPipesPipe_sqsSourceRedshiftTarget (351.82s)
=== CONT  TestAccPipesPipe_activeMQSourceStepFunctionTarget
--- PASS: TestAccPipesPipe_rabbitMQSourceEventBusTarget (758.12s)
=== CONT  TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
--- PASS: TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget (54.28s)
=== CONT  TestAccPipesPipe_kinesisSourceAndTarget
--- PASS: TestAccPipesPipe_kinesisSourceAndTarget (72.33s)
=== CONT  TestAccPipesPipe_targetParameters_inputTemplate
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (178.53s)
=== CONT  TestAccPipesPipe_targetUpdate
--- PASS: TestAccPipesPipe_targetUpdate (147.86s)
=== CONT  TestAccPipesPipe_tags
--- PASS: TestAccPipesPipe_tags (133.34s)
=== CONT  TestAccPipesPipe_roleARN
--- PASS: TestAccPipesPipe_activeMQSourceStepFunctionTarget (1076.08s)
=== CONT  TestAccPipesPipe_namePrefix
--- PASS: TestAccPipesPipe_namePrefix (98.60s)
=== CONT  TestAccPipesPipe_nameGenerated
--- PASS: TestAccPipesPipe_roleARN (152.99s)
=== CONT  TestAccPipesPipe_sourceParameters_filterCriteria
--- PASS: TestAccPipesPipe_nameGenerated (92.34s)
=== CONT  TestAccPipesPipe_enrichmentParameters
--- PASS: TestAccPipesPipe_enrichmentParameters (136.30s)
=== CONT  TestAccPipesPipe_enrichment
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (285.44s)
=== CONT  TestAccPipesPipe_desiredState
--- PASS: TestAccPipesPipe_enrichment (169.80s)
=== CONT  TestAccPipesPipe_description
--- PASS: TestAccPipesPipe_desiredState (181.63s)
=== CONT  TestAccPipesPipe_disappears
--- PASS: TestAccPipesPipe_disappears (109.34s)
--- PASS: TestAccPipesPipe_description (239.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	2287.360s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/pipes Issues and PRs that pertain to the pipes service. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 20, 2023
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jul 20, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jul 20, 2023
@ewbankkit ewbankkit merged commit 5bd43a0 into main Jul 20, 2023
@ewbankkit ewbankkit deleted the b-aws_pipes_pipe-update-error branch July 20, 2023 18:41
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 20, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/pipes Issues and PRs that pertain to the pipes service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot update EventBridge Pipe in place when source is DynamoDB Stream
1 participant