Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_storagegateway_smb_file_share: Set kms_key_arn when kms_encrypted is true #32171

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

johnsonaj
Copy link
Contributor

Description

Resolve error during an update when kms_encrypted is true but kms_key_arn is not sent in the request.

Relations

Closes #20766

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccStorageGatewaySMBFileShare_' PKG=storagegateway

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 20  -run=TestAccStorageGatewaySMBFileShare_ -timeout 180m
--- PASS: TestAccStorageGatewaySMBFileShare_Authentication_guestAccess (345.92s)
--- PASS: TestAccStorageGatewaySMBFileShare_guessMIMETypeEnabled (394.40s)
--- PASS: TestAccStorageGatewaySMBFileShare_disappears (395.55s)
--- PASS: TestAccStorageGatewaySMBFileShare_encryptedUpdate (410.67s)
--- PASS: TestAccStorageGatewaySMBFileShare_audit (411.60s)
--- PASS: TestAccStorageGatewaySMBFileShare_objectACL (424.00s)
--- PASS: TestAccStorageGatewaySMBFileShare_readOnly (434.67s)
--- PASS: TestAccStorageGatewaySMBFileShare_fileShareName (443.06s)
--- PASS: TestAccStorageGatewaySMBFileShare_defaultStorageClass (443.16s)
--- PASS: TestAccStorageGatewaySMBFileShare_accessBasedEnumeration (449.45s)
--- PASS: TestAccStorageGatewaySMBFileShare_kmsKeyARN (449.87s)
--- PASS: TestAccStorageGatewaySMBFileShare_requesterPays (453.36s)
--- PASS: TestAccStorageGatewaySMBFileShare_cacheAttributes (464.34s)
--- PASS: TestAccStorageGatewaySMBFileShare_caseSensitivity (483.75s)
--- PASS: TestAccStorageGatewaySMBFileShare_notificationPolicy (483.95s)
--- PASS: TestAccStorageGatewaySMBFileShare_kmsEncrypted (319.21s)
--- PASS: TestAccStorageGatewaySMBFileShare_tags (371.39s)
--- PASS: TestAccStorageGatewaySMBFileShare_Authentication_activeDirectory (1071.96s)
--- PASS: TestAccStorageGatewaySMBFileShare_SMB_acl (1137.82s)
--- PASS: TestAccStorageGatewaySMBFileShare_validUserList (1151.34s)
--- PASS: TestAccStorageGatewaySMBFileShare_adminUserList (1153.71s)
--- PASS: TestAccStorageGatewaySMBFileShare_invalidUserList (1397.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	1400.765s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Jun 22, 2023
@github-actions github-actions bot added service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 22, 2023
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM 🎉

internal/service/storagegateway/smb_file_share_test.go Outdated Show resolved Hide resolved
internal/service/storagegateway/smb_file_share_test.go Outdated Show resolved Hide resolved
johnsonaj and others added 2 commits June 22, 2023 13:40
Co-authored-by: Dirk Avery <[email protected]>
Co-authored-by: Dirk Avery <[email protected]>
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Jun 22, 2023
@johnsonaj johnsonaj merged commit 36eca54 into main Jun 22, 2023
47 of 48 checks passed
@johnsonaj johnsonaj deleted the b-storagegateway_smb_file_share_update branch June 22, 2023 19:44
@github-actions github-actions bot added this to the v5.5.0 milestone Jun 22, 2023
github-actions bot pushed a commit that referenced this pull request Jun 22, 2023
@github-actions
Copy link

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"KMSEncrypted is set to true, but KMSKey is missing." when updating aws_storagegateway_smb_file_share
2 participants