-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resource): Add new docdbelastic_cluster resource #31033
Conversation
Community NoteVoting for Prioritization
For Submitters
|
322136d
to
fdd21e7
Compare
dd3a039
to
01550c0
Compare
01550c0
to
0ad849f
Compare
Any updates on when we could expect this merge? My team is eager to adopt elastic doc_dbs |
It looks like this code has been done for about 2 months and all checks have passed. Is there an update on when it can be merged in? |
We do need this too! |
update on this PR? |
Need this too. @johnsonaj, just saw you self-assigned this, will you be taking on this PR? Can you provide an update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS="-run=TestAccDocDBElasticCluster_" PKG=docdbelastic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdbelastic/... -v -count 1 -parallel 20 -run=TestAccDocDBElasticCluster_ -timeout 360m
=== RUN TestAccDocDBElasticCluster_basic
=== PAUSE TestAccDocDBElasticCluster_basic
=== RUN TestAccDocDBElasticCluster_disappears
=== PAUSE TestAccDocDBElasticCluster_disappears
=== RUN TestAccDocDBElasticCluster_tags
=== PAUSE TestAccDocDBElasticCluster_tags
=== RUN TestAccDocDBElasticCluster_update
=== PAUSE TestAccDocDBElasticCluster_update
=== CONT TestAccDocDBElasticCluster_basic
=== CONT TestAccDocDBElasticCluster_tags
=== CONT TestAccDocDBElasticCluster_update
=== CONT TestAccDocDBElasticCluster_disappears
--- PASS: TestAccDocDBElasticCluster_disappears (2972.00s)
--- PASS: TestAccDocDBElasticCluster_basic (3009.98s)
--- PASS: TestAccDocDBElasticCluster_tags (3022.32s)
--- PASS: TestAccDocDBElasticCluster_update (3856.19s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/docdbelastic 3859.453s
@amacf thank you for the contribution! 🎉 |
This functionality has been released in v5.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Implements the cluster resource for docdbelastic service
Note that this does not implement the cluster snaphots resource, which will be saved for another PR.
Relations
Closes #29514
References
Output from Acceptance Testing