Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): Add new docdbelastic_cluster resource #31033

Merged
merged 15 commits into from
Nov 29, 2023

Conversation

amacf
Copy link
Contributor

@amacf amacf commented Apr 27, 2023

Description

Implements the cluster resource for docdbelastic service

Note that this does not implement the cluster snaphots resource, which will be saved for another PR.

Relations

Closes #29514

References

Output from Acceptance Testing

terraform-provider-aws$ make testacc TESTS=TestAccDocDBElasticCluster PKG=docdbelastic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdbelastic/... -v -count 1 -parallel 20 -run='TestAccDocDBElasticCluster'  -timeout 180m
=== RUN   TestAccDocDBElasticCluster_basic
=== PAUSE TestAccDocDBElasticCluster_basic
=== RUN   TestAccDocDBElasticCluster_disappears
=== PAUSE TestAccDocDBElasticCluster_disappears
=== CONT  TestAccDocDBElasticCluster_basic
=== CONT  TestAccDocDBElasticCluster_disappears
--- PASS: TestAccDocDBElasticCluster_disappears (2379.71s)
--- PASS: TestAccDocDBElasticCluster_basic (2403.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdbelastic	2403.354s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 27, 2023
@amacf amacf force-pushed the f-docdbelastic-cluster branch 5 times, most recently from 322136d to fdd21e7 Compare April 27, 2023 22:47
@amacf amacf changed the title feat: Add new docdbelastic_cluster resource feat(resource): Add new docdbelastic_cluster resource Apr 27, 2023
@amacf amacf force-pushed the f-docdbelastic-cluster branch 2 times, most recently from dd3a039 to 01550c0 Compare April 27, 2023 23:01
@amacf amacf marked this pull request as ready for review April 28, 2023 00:12
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 28, 2023
@philipleetaylor
Copy link

Any updates on when we could expect this merge? My team is eager to adopt elastic doc_dbs

@jtbrush56
Copy link

It looks like this code has been done for about 2 months and all checks have passed. Is there an update on when it can be merged in?

@eugenestarchenko
Copy link

We do need this too!

@zikphil
Copy link

zikphil commented Sep 11, 2023

update on this PR?

@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2023
@johnsonaj johnsonaj self-assigned this Nov 27, 2023
@lagerfeuer
Copy link
Contributor

Need this too. @johnsonaj, just saw you self-assigned this, will you be taking on this PR? Can you provide an update?

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccDocDBElasticCluster_" PKG=docdbelastic

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdbelastic/... -v -count 1 -parallel 20  -run=TestAccDocDBElasticCluster_ -timeout 360m
=== RUN   TestAccDocDBElasticCluster_basic
=== PAUSE TestAccDocDBElasticCluster_basic
=== RUN   TestAccDocDBElasticCluster_disappears
=== PAUSE TestAccDocDBElasticCluster_disappears
=== RUN   TestAccDocDBElasticCluster_tags
=== PAUSE TestAccDocDBElasticCluster_tags
=== RUN   TestAccDocDBElasticCluster_update
=== PAUSE TestAccDocDBElasticCluster_update
=== CONT  TestAccDocDBElasticCluster_basic
=== CONT  TestAccDocDBElasticCluster_tags
=== CONT  TestAccDocDBElasticCluster_update
=== CONT  TestAccDocDBElasticCluster_disappears
--- PASS: TestAccDocDBElasticCluster_disappears (2972.00s)
--- PASS: TestAccDocDBElasticCluster_basic (3009.98s)
--- PASS: TestAccDocDBElasticCluster_tags (3022.32s)
--- PASS: TestAccDocDBElasticCluster_update (3856.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdbelastic	3859.453s

@johnsonaj
Copy link
Contributor

@amacf thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit fb0c549 into hashicorp:main Nov 29, 2023
44 checks passed
@github-actions github-actions bot added this to the v5.29.0 milestone Nov 29, 2023
Copy link

github-actions bot commented Dec 1, 2023

This functionality has been released in v5.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: DocumentDB - Elastic Clusters
9 participants