Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Deprecate data source tags_all attributes #30710

Closed
ewbankkit opened this issue Apr 13, 2023 · 4 comments
Closed

Tech debt: Deprecate data source tags_all attributes #30710

ewbankkit opened this issue Apr 13, 2023 · 4 comments
Assignees
Labels
tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Apr 13, 2023

Data sources should not have a tags_all attribute.
A couple do:

  • aws_quicksight_data_set
  • aws_service_discovery_service

Deprecate and then remove these.
Add a semgrep rule to prevent future cases.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title Tech debt: Deprecate data source 'tags_all' attributes Tech debt: Deprecate data source tags_all attributes Apr 13, 2023
@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Apr 13, 2023
@ewbankkit ewbankkit added this to the v5.0.0 milestone Apr 13, 2023
@ewbankkit ewbankkit added the tags Pertains to resource tagging. label Apr 13, 2023
@ewbankkit ewbankkit self-assigned this May 4, 2023
@johnsonaj
Copy link
Contributor

Closed in #31162. Merged to main in #31392

@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

No branches or pull requests

2 participants