Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media insights pipeline configuration resource #30603

Merged
merged 14 commits into from
Apr 13, 2023
Merged

Add media insights pipeline configuration resource #30603

merged 14 commits into from
Apr 13, 2023

Conversation

lognoel
Copy link
Contributor

@lognoel lognoel commented Apr 10, 2023

Description

Add aws_chimesdkmediapipelines_media_insights_pipeline_configuration resource

Relations

Relates #30300

References

Output from Acceptance Testing

 make testacc PKG=chimesdkmediapipelines
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkmediapipelines/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic
=== PAUSE TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic
=== RUN   TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears
=== PAUSE TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears
=== RUN   TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes
=== PAUSE TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes
=== CONT  TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic
=== CONT  TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes
=== CONT  TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears (46.96s)
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic (57.31s)
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes (149.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkmediapipelines     154.076s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Apr 10, 2023
@lognoel lognoel marked this pull request as ready for review April 10, 2023 22:30
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 11, 2023
@jar-b jar-b self-assigned this Apr 13, 2023
jar-b added 10 commits April 13, 2023 10:47
@jar-b
r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: p…
71e1ce8 
…refer flex expanders
@jar-b
r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: r…
67353f9 
…eplace log.Fatal
@jar-b
r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: f…
e75ae5a 
…inder in test check func
@jar-b
r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: c…
36d1624 
…ompose test configs, add tags test
@jar-b
r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: o…
ec69f82 
…ptional/required casing
@jar-b
r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: i…
38b24b3 
…mport with id
@jar-b
r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: t…
33f0bcb 
…ransparent tagging
@jar-b
Merge branch 'main' into f-chime-sdk-media-insights
6df9ef1
@jar-b
chore: make gen
4a52e7b
@jar-b
r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: u…
5ecce45 
…se names tag attributes
jar-b
jar-b approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=chimesdkmediapipelines
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkmediapipelines/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic
=== PAUSE TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic
=== RUN   TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears
=== PAUSE TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears
=== RUN   TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes
=== PAUSE TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes
=== RUN   TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_tags
=== PAUSE TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_tags
=== CONT  TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic
=== CONT  TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes
=== CONT  TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears
=== CONT  TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_tags
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears (44.89s)
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic (54.16s)
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_tags (66.69s)
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes (126.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkmediapipelines     129.392s

@jar-b jar-b merged commit 8f5906a into hashicorp:main Apr 13, 2023
@jar-b
Copy link
Member

jar-b commented Apr 13, 2023

Thanks for your contribution, @lognoel! 👏

@github-actions github-actions bot added this to the v4.63.0 milestone Apr 13, 2023
@lognoel
Copy link
Contributor Author

lognoel commented Apr 13, 2023

Thanks @jar-b!

@lognoel lognoel mentioned this pull request Apr 13, 2023
Merged
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@lognoel lognoel deleted the f-chime-sdk-media-insights branch April 14, 2023 16:45
alewando pushed a commit to alewando/terraform-provider-aws that referenced this pull request Apr 14, 2023
@lognoel @jar-b
Add media insights pipeline configuration resource (hashicorp#30603)
50370b7 
* Add media insights pipeline configuration resource

* added changelog for 30603

* add website lint fixes

* add lint fixes for acceptance tests

* r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: prefer flex expanders

* r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: replace log.Fatal

* r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: finder in test check func

* r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: compose test configs, add tags test

* r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: optional/required casing

* r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: import with id

* r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: transparent tagging

* chore: make gen

* r/aws_chimesdkmediapipelines_media_insights_pipeline_configuration: use names tag attributes

---------

Co-authored-by: Jared Baker <[email protected]>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.63.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lognoel @jar-b @ewbankkit @justinretzolk