Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds/cluster/parameter_group: Diffs #30536

Merged
merged 4 commits into from
Apr 10, 2023
Merged

rds/cluster/parameter_group: Diffs #30536

merged 4 commits into from
Apr 10, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 7, 2023

Description

Relations

Closes #12742

References

Output from Acceptance Testing

% make t T=TestAccRDSClusterParameterGroup_ K=rds            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterParameterGroup_'  -timeout 180m
=== RUN   TestAccRDSClusterParameterGroup_basic
=== PAUSE TestAccRDSClusterParameterGroup_basic
=== RUN   TestAccRDSClusterParameterGroup_disappears
=== PAUSE TestAccRDSClusterParameterGroup_disappears
=== RUN   TestAccRDSClusterParameterGroup_tags
=== PAUSE TestAccRDSClusterParameterGroup_tags
=== RUN   TestAccRDSClusterParameterGroup_withApplyMethod
=== PAUSE TestAccRDSClusterParameterGroup_withApplyMethod
=== RUN   TestAccRDSClusterParameterGroup_namePrefix
=== PAUSE TestAccRDSClusterParameterGroup_namePrefix
=== RUN   TestAccRDSClusterParameterGroup_NamePrefix_parameter
=== PAUSE TestAccRDSClusterParameterGroup_NamePrefix_parameter
=== RUN   TestAccRDSClusterParameterGroup_generatedName
=== PAUSE TestAccRDSClusterParameterGroup_generatedName
=== RUN   TestAccRDSClusterParameterGroup_GeneratedName_parameter
=== PAUSE TestAccRDSClusterParameterGroup_GeneratedName_parameter
=== RUN   TestAccRDSClusterParameterGroup_only
=== PAUSE TestAccRDSClusterParameterGroup_only
=== RUN   TestAccRDSClusterParameterGroup_updateParameters
=== PAUSE TestAccRDSClusterParameterGroup_updateParameters
=== RUN   TestAccRDSClusterParameterGroup_caseParameters
=== PAUSE TestAccRDSClusterParameterGroup_caseParameters
=== RUN   TestAccRDSClusterParameterGroup_dynamicDiffs
=== PAUSE TestAccRDSClusterParameterGroup_dynamicDiffs
=== CONT  TestAccRDSClusterParameterGroup_basic
=== CONT  TestAccRDSClusterParameterGroup_generatedName
=== CONT  TestAccRDSClusterParameterGroup_namePrefix
=== CONT  TestAccRDSClusterParameterGroup_updateParameters
=== CONT  TestAccRDSClusterParameterGroup_tags
=== CONT  TestAccRDSClusterParameterGroup_disappears
=== CONT  TestAccRDSClusterParameterGroup_only
=== CONT  TestAccRDSClusterParameterGroup_NamePrefix_parameter
=== CONT  TestAccRDSClusterParameterGroup_withApplyMethod
=== CONT  TestAccRDSClusterParameterGroup_dynamicDiffs
=== CONT  TestAccRDSClusterParameterGroup_GeneratedName_parameter
=== CONT  TestAccRDSClusterParameterGroup_caseParameters
--- PASS: TestAccRDSClusterParameterGroup_disappears (22.52s)
--- PASS: TestAccRDSClusterParameterGroup_dynamicDiffs (27.08s)
--- PASS: TestAccRDSClusterParameterGroup_only (29.39s)
--- PASS: TestAccRDSClusterParameterGroup_withApplyMethod (33.01s)
--- PASS: TestAccRDSClusterParameterGroup_NamePrefix_parameter (33.28s)
--- PASS: TestAccRDSClusterParameterGroup_namePrefix (33.38s)
--- PASS: TestAccRDSClusterParameterGroup_GeneratedName_parameter (34.91s)
--- PASS: TestAccRDSClusterParameterGroup_generatedName (41.19s)
--- PASS: TestAccRDSClusterParameterGroup_caseParameters (43.07s)
--- PASS: TestAccRDSClusterParameterGroup_updateParameters (47.14s)
--- PASS: TestAccRDSClusterParameterGroup_tags (62.56s)
--- PASS: TestAccRDSClusterParameterGroup_basic (70.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	72.501s

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. labels Apr 7, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. labels Apr 7, 2023
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Apr 7, 2023
@github-actions github-actions bot added the generators Relates to code generators. label Apr 8, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSClusterParameterGroup_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterParameterGroup_ -timeout 180m
=== RUN   TestAccRDSClusterParameterGroup_basic
=== PAUSE TestAccRDSClusterParameterGroup_basic
=== RUN   TestAccRDSClusterParameterGroup_disappears
=== PAUSE TestAccRDSClusterParameterGroup_disappears
=== RUN   TestAccRDSClusterParameterGroup_tags
=== PAUSE TestAccRDSClusterParameterGroup_tags
=== RUN   TestAccRDSClusterParameterGroup_withApplyMethod
=== PAUSE TestAccRDSClusterParameterGroup_withApplyMethod
=== RUN   TestAccRDSClusterParameterGroup_namePrefix
=== PAUSE TestAccRDSClusterParameterGroup_namePrefix
=== RUN   TestAccRDSClusterParameterGroup_NamePrefix_parameter
=== PAUSE TestAccRDSClusterParameterGroup_NamePrefix_parameter
=== RUN   TestAccRDSClusterParameterGroup_generatedName
=== PAUSE TestAccRDSClusterParameterGroup_generatedName
=== RUN   TestAccRDSClusterParameterGroup_GeneratedName_parameter
=== PAUSE TestAccRDSClusterParameterGroup_GeneratedName_parameter
=== RUN   TestAccRDSClusterParameterGroup_only
=== PAUSE TestAccRDSClusterParameterGroup_only
=== RUN   TestAccRDSClusterParameterGroup_updateParameters
=== PAUSE TestAccRDSClusterParameterGroup_updateParameters
=== RUN   TestAccRDSClusterParameterGroup_caseParameters
=== PAUSE TestAccRDSClusterParameterGroup_caseParameters
=== RUN   TestAccRDSClusterParameterGroup_dynamicDiffs
=== PAUSE TestAccRDSClusterParameterGroup_dynamicDiffs
=== CONT  TestAccRDSClusterParameterGroup_basic
=== CONT  TestAccRDSClusterParameterGroup_generatedName
--- PASS: TestAccRDSClusterParameterGroup_generatedName (20.98s)
=== CONT  TestAccRDSClusterParameterGroup_updateParameters
--- PASS: TestAccRDSClusterParameterGroup_updateParameters (30.80s)
=== CONT  TestAccRDSClusterParameterGroup_dynamicDiffs
--- PASS: TestAccRDSClusterParameterGroup_dynamicDiffs (13.75s)
=== CONT  TestAccRDSClusterParameterGroup_caseParameters
--- PASS: TestAccRDSClusterParameterGroup_basic (74.90s)
=== CONT  TestAccRDSClusterParameterGroup_only
--- PASS: TestAccRDSClusterParameterGroup_only (17.25s)
=== CONT  TestAccRDSClusterParameterGroup_withApplyMethod
--- PASS: TestAccRDSClusterParameterGroup_caseParameters (27.31s)
=== CONT  TestAccRDSClusterParameterGroup_NamePrefix_parameter
--- PASS: TestAccRDSClusterParameterGroup_withApplyMethod (17.81s)
=== CONT  TestAccRDSClusterParameterGroup_namePrefix
--- PASS: TestAccRDSClusterParameterGroup_NamePrefix_parameter (18.22s)
=== CONT  TestAccRDSClusterParameterGroup_GeneratedName_parameter
--- PASS: TestAccRDSClusterParameterGroup_namePrefix (16.89s)
=== CONT  TestAccRDSClusterParameterGroup_tags
--- PASS: TestAccRDSClusterParameterGroup_GeneratedName_parameter (17.77s)
=== CONT  TestAccRDSClusterParameterGroup_disappears
--- PASS: TestAccRDSClusterParameterGroup_disappears (12.28s)
--- PASS: TestAccRDSClusterParameterGroup_tags (40.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	173.191s

@YakDriver YakDriver merged commit d481c9b into main Apr 10, 2023
@YakDriver YakDriver deleted the b-parameter-group-rds-diff branch April 10, 2023 18:27
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 10, 2023
github-actions bot pushed a commit that referenced this pull request Apr 10, 2023
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. generators Relates to code generators. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS RDS Cluster Parameter Group changes are repeated every time
2 participants