new resource: `aws_sagemaker_data_quality_job_definition` #30301

wrbooth · 2023-03-28T23:31:51Z

Description

Adds a new resource:

aws_sagemaker_data_quality_job_definition: A definition of a job that monitors data quality and drift for sagemaker endpoints or batch transforms.

Adds sagemaker-model-monitor-analyzer to aws_sagemaker_prebuilt_ecr_image data source.

Relations

Relates #29768.

References

CreateDataQualityJobDefinition Documentation

Output from Acceptance Testing

❯ make testacc TESTS=TestAccSageMakerDataQualityJobDefinition PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerDataQualityJobDefinition'  -timeout 180m
=== RUN   TestAccSageMakerDataQualityJobDefinition_endpoint
=== PAUSE TestAccSageMakerDataQualityJobDefinition_endpoint
=== RUN   TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
=== RUN   TestAccSageMakerDataQualityJobDefinition_baselineConfig
=== PAUSE TestAccSageMakerDataQualityJobDefinition_baselineConfig
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransform
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransform
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransformCsvHeader
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformCsvHeader
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransformJson
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformJson
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransformJsonLine
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformJsonLine
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
=== RUN   TestAccSageMakerDataQualityJobDefinition_endpointOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_endpointOptional
=== RUN   TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== PAUSE TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== RUN   TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
=== RUN   TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
=== PAUSE TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
=== RUN   TestAccSageMakerDataQualityJobDefinition_stoppingCondition
=== PAUSE TestAccSageMakerDataQualityJobDefinition_stoppingCondition
=== RUN   TestAccSageMakerDataQualityJobDefinition_networkConfig
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfig
=== RUN   TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
=== RUN   TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
=== RUN   TestAccSageMakerDataQualityJobDefinition_tags
=== PAUSE TestAccSageMakerDataQualityJobDefinition_tags
=== RUN   TestAccSageMakerDataQualityJobDefinition_disappears
=== PAUSE TestAccSageMakerDataQualityJobDefinition_disappears
=== CONT  TestAccSageMakerDataQualityJobDefinition_endpoint
=== CONT  TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransformJson
=== CONT  TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
=== CONT  TestAccSageMakerDataQualityJobDefinition_stoppingCondition
=== CONT  TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
=== CONT  TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
=== CONT  TestAccSageMakerDataQualityJobDefinition_disappears
=== CONT  TestAccSageMakerDataQualityJobDefinition_tags
=== CONT  TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransformJsonLine
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransform
=== CONT  TestAccSageMakerDataQualityJobDefinition_endpointOptional
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransformCsvHeader
=== CONT  TestAccSageMakerDataQualityJobDefinition_networkConfig
=== CONT  TestAccSageMakerDataQualityJobDefinition_baselineConfig
=== CONT  TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId (46.58s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_outputConfigOptional (48.37s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation (51.35s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformJson (53.48s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_baselineConfig (54.07s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId (55.10s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfig (55.39s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_disappears (61.75s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransform (63.27s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformOptional (63.44s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional (65.97s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformCsvHeader (66.47s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformJsonLine (66.71s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption (68.21s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_stoppingCondition (70.17s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_tags (99.12s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_endpointOptional (240.34s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_endpoint (300.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	302.730s
❯

github-actions

Welcome @wrbooth 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

DrFaust92 · 2023-04-06T19:19:34Z

Hi wrbooth, please split this PR to a resource per PR (as contribution guide suggests)

wrbooth · 2023-04-07T04:47:53Z

Hi wrbooth, please split this PR to a resource per PR (as contribution guide suggests)

Very sorry about that! I've removed aws_sagemaker_monitoring_schedule from this PR. Looks like I'll need to wait until this PR is merged to file the PR for aws_sagemaker_monitoring_schedule, as this resource is dependent on the other.

…afmt errors.

…d by blank lines'.

…mt errors.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerDataQualityJobDefinition_' PKG=sagemaker ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 3  -run=TestAccSageMakerDataQualityJobDefinition_ -timeout 180m
=== RUN   TestAccSageMakerDataQualityJobDefinition_endpoint
=== PAUSE TestAccSageMakerDataQualityJobDefinition_endpoint
=== RUN   TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
=== RUN   TestAccSageMakerDataQualityJobDefinition_baselineConfig
=== PAUSE TestAccSageMakerDataQualityJobDefinition_baselineConfig
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransform
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransform
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransformCSVHeader
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformCSVHeader
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransformJSON
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformJSON
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransformJSONLine
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformJSONLine
=== RUN   TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
=== RUN   TestAccSageMakerDataQualityJobDefinition_endpointOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_endpointOptional
=== RUN   TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== PAUSE TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== RUN   TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
=== PAUSE TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
=== RUN   TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
=== PAUSE TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
=== RUN   TestAccSageMakerDataQualityJobDefinition_stoppingCondition
=== PAUSE TestAccSageMakerDataQualityJobDefinition_stoppingCondition
=== RUN   TestAccSageMakerDataQualityJobDefinition_networkConfig
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfig
=== RUN   TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
=== RUN   TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
=== PAUSE TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
=== RUN   TestAccSageMakerDataQualityJobDefinition_tags
=== PAUSE TestAccSageMakerDataQualityJobDefinition_tags
=== RUN   TestAccSageMakerDataQualityJobDefinition_disappears
=== PAUSE TestAccSageMakerDataQualityJobDefinition_disappears
=== CONT  TestAccSageMakerDataQualityJobDefinition_endpoint
=== CONT  TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransformJSON
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformJSON (25.91s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption
--- PASS: TestAccSageMakerDataQualityJobDefinition_ouputConfigKmsKeyId (28.42s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_disappears
--- PASS: TestAccSageMakerDataQualityJobDefinition_disappears (21.89s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_tags
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfigTrafficEncryption (27.99s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfigEnableNetworkIsolation (26.35s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransform
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransform (23.30s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransformCSVHeader
--- PASS: TestAccSageMakerDataQualityJobDefinition_tags (55.71s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_baselineConfig
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformCSVHeader (24.26s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_stoppingCondition
--- PASS: TestAccSageMakerDataQualityJobDefinition_baselineConfig (24.32s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_networkConfig
--- PASS: TestAccSageMakerDataQualityJobDefinition_stoppingCondition (22.95s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransformOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_networkConfig (26.39s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_endpointOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformOptional (29.03s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId
--- PASS: TestAccSageMakerDataQualityJobDefinition_jobResourcesVolumeKmsKeyId (30.52s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_batchTransformJSONLine
--- PASS: TestAccSageMakerDataQualityJobDefinition_endpoint (231.40s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_outputConfigOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_batchTransformJSONLine (46.74s)
=== CONT  TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional
--- PASS: TestAccSageMakerDataQualityJobDefinition_outputConfigOptional (62.26s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_appSpecificationOptional (52.44s)
--- PASS: TestAccSageMakerDataQualityJobDefinition_endpointOptional (354.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	516.677s

…afmt errors.

ewbankkit · 2023-04-11T21:32:18Z

@wrbooth Thanks for the contribution 🎉 👏.

wrbooth · 2023-04-12T20:07:38Z

@wrbooth Thanks for the contribution 🎉 👏.

Sure thing! Thanks for the quick review and all the additions to get it merged!

I've just filed PR #30684 for the remainder of the code per request.

github-actions · 2023-04-14T11:51:16Z

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-05-15T02:13:12Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bb-adsk added 30 commits March 7, 2023 14:20

first pass at data_quality_job_definition resource

d2fd83b

adding full data quality job def api

3c527d3

add model monitor data source

2eab0a2

bug fixes

87c4f66

add first data quality job definition test

4eef786

add disappears test

1d30a30

adding more to base test

13cf0e6

add appspc optional test

cb58862

add baseline config test

8746235

fixed a couple of bugs with csv field

b5db420

adding batch transform test

f6b54d7

fixing issues with transform job input

8b6ff11

adding transform job tests

2e0b3a7

fixes to endpoint optional parameters

eabcd24

adding endpoint optional test

9d45d3d

add outputconfig kmskeyid test

b988e74

fix monitoring_outputs bug

f6157a7

add outconfig optional test

387af00

adding job resources kms key test

efa7903

add stopping condition test

6faeb6c

add tags test

c6b4c9f

clean up tests

0e1aacf

test name cleanup

10352c5

more test cleanup

2c08d43

adding network config tests

d5cc8b2

first pass at ading monitoring_schedule resource

5b61d30

add monitring schedule disappears test

0b073ed

adding monitoring schedule tags test

fdfc3f4

adding schedule_config

51ad83f

Merge branch 'main' into f-aws_sagemaker_model_monitoring_schedule

5a2e5ae

github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Mar 28, 2023

add changelog for PR

b2487f9

github-actions bot reviewed Mar 28, 2023

View reviewed changes

justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 29, 2023

remove monitoring schedule from branch

891884a

wrbooth changed the title ~~new resources: aws_sagemaker_monitoring_schedule and aws_sagemaker_data_quality_job_definition~~ new resource: aws_sagemaker_data_quality_job_definition Apr 7, 2023

ewbankkit added 9 commits April 11, 2023 16:23

Merge branch 'main' into HEAD

4fed380

r/aws_sagemaker_data_quality_job_definition: Fix acceptance test terr…

3551c2f

…afmt errors.

Fix semgrep 'ci.caps2-in-func-name'.

57e4f65

Fix markdownlint 'MD032/blanks-around-lists Lists should be surrounde…

9ab42a1

…d by blank lines'.

r/aws_sagemaker_data_quality_job_definition: Fix documentation terraf…

ae63249

…mt errors.

Fix semgrep 'ci.caps2-in-func-name'.

c803f10

Fix compilation errors.

d0d1cee

Correctly order CRUD handlers.

370acd5

r/aws_sagemaker_data_quality_job_definition: Transparent tagging.

96294e3

ewbankkit approved these changes Apr 11, 2023

View reviewed changes

ewbankkit added 2 commits April 11, 2023 17:26

r/aws_sagemaker_data_quality_job_definition: Fix acceptance test terr…

239cb5f

…afmt errors.

Fix semgrep 'ci.caps4-in-func-name'.

1104768

ewbankkit merged commit 6405141 into hashicorp:main Apr 11, 2023

github-actions bot added this to the v4.63.0 milestone Apr 11, 2023

github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new resource: `aws_sagemaker_data_quality_job_definition` #30301

new resource: `aws_sagemaker_data_quality_job_definition` #30301

wrbooth commented Mar 28, 2023 •

edited by ewbankkit

Loading

github-actions bot left a comment

DrFaust92 commented Apr 6, 2023

wrbooth commented Apr 7, 2023 •

edited

Loading

ewbankkit left a comment

ewbankkit commented Apr 11, 2023

wrbooth commented Apr 12, 2023

github-actions bot commented Apr 14, 2023

github-actions bot commented May 15, 2023

new resource: aws_sagemaker_data_quality_job_definition #30301

new resource: aws_sagemaker_data_quality_job_definition #30301

Conversation

wrbooth commented Mar 28, 2023 • edited by ewbankkit Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot left a comment

Choose a reason for hiding this comment

DrFaust92 commented Apr 6, 2023

wrbooth commented Apr 7, 2023 • edited Loading

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Apr 11, 2023

wrbooth commented Apr 12, 2023

github-actions bot commented Apr 14, 2023

github-actions bot commented May 15, 2023

new resource: `aws_sagemaker_data_quality_job_definition` #30301

new resource: `aws_sagemaker_data_quality_job_definition` #30301

wrbooth commented Mar 28, 2023 •

edited by ewbankkit

Loading

wrbooth commented Apr 7, 2023 •

edited

Loading