feat: added IPv6 support to Route53 Resolver Endpoint and Forward rule

[tamiros]

Description

This PR adds:

• resolver_endpoint_type attribute to the aws_route53_resolver_endpoint resource.
• ipv6 attribute to the target_ip struct of the aws_route53_resolver_rule resource.

Relations

Closes #30075

References

https://aws.amazon.com/about-aws/whats-new/2023/03/amazon-route-53-resolver-endpoints-hybrid-cloud-ipv6-support/

Output from Acceptance Testing

make testacc TESTS='TestAccRoute53ResolverEndpoint_basic_ipv6' PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverEndpoint_basic_ipv6'  -timeout 180m
=== RUN   TestAccRoute53ResolverEndpoint_basic_ipv6
=== PAUSE TestAccRoute53ResolverEndpoint_basic_ipv6
=== CONT  TestAccRoute53ResolverEndpoint_basic_ipv6
--- PASS: TestAccRoute53ResolverEndpoint_basic_ipv6 (97.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    97.337s

...
make testacc TESTS='TestAccRoute53ResolverRule_forward_ipv6' PKG=route53resolver TESTARGS=-short ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 1 -run='TestAccRoute53ResolverRule_forward_ipv6' -short -timeout 180m
=== RUN   TestAccRoute53ResolverRule_forward_ipv6
=== PAUSE TestAccRoute53ResolverRule_forward_ipv6
=== CONT  TestAccRoute53ResolverRule_forward_ipv6
--- PASS: TestAccRoute53ResolverRule_forward_ipv6 (317.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    318.072s

...
make testacc TESTS='TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6' PKG=route53resolver TESTARGS=-short ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 1 -run='TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6' -short -timeout 180m
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6 (432.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    432.698s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @tamiros 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[kongdewen]

Is there any targeted release date for this?

[nam054]

LGTM 🚀 Thank you for your contribution!

> make testacc TESTARGS="-run=TestAccRoute53ResolverEndpoint_" PKG=route53resolver
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53resolver/... -v -count 1 -parallel 20  -run=TestAccRoute53ResolverEndpoint_ -timeout 360m
=== RUN   TestAccRoute53ResolverEndpoint_basic
=== PAUSE TestAccRoute53ResolverEndpoint_basic
=== RUN   TestAccRoute53ResolverEndpoint_basic_ipv6
=== PAUSE TestAccRoute53ResolverEndpoint_basic_ipv6
=== RUN   TestAccRoute53ResolverEndpoint_disappears
=== PAUSE TestAccRoute53ResolverEndpoint_disappears
=== RUN   TestAccRoute53ResolverEndpoint_tags
=== PAUSE TestAccRoute53ResolverEndpoint_tags
=== RUN   TestAccRoute53ResolverEndpoint_updateOutbound
=== PAUSE TestAccRoute53ResolverEndpoint_updateOutbound
=== RUN   TestAccRoute53ResolverEndpoint_resolverEndpointType
=== PAUSE TestAccRoute53ResolverEndpoint_resolverEndpointType
=== CONT  TestAccRoute53ResolverEndpoint_basic
=== CONT  TestAccRoute53ResolverEndpoint_tags
=== CONT  TestAccRoute53ResolverEndpoint_disappears
=== CONT  TestAccRoute53ResolverEndpoint_resolverEndpointType
=== CONT  TestAccRoute53ResolverEndpoint_basic_ipv6
=== CONT  TestAccRoute53ResolverEndpoint_updateOutbound
--- PASS: TestAccRoute53ResolverEndpoint_basic_ipv6 (94.22s)
--- PASS: TestAccRoute53ResolverEndpoint_disappears (102.04s)
--- PASS: TestAccRoute53ResolverEndpoint_basic (104.56s)
--- PASS: TestAccRoute53ResolverEndpoint_tags (127.51s)
--- PASS: TestAccRoute53ResolverEndpoint_resolverEndpointType (157.03s)
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (330.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    336.070s
> make testacc TESTARGS="-run=TestAccRoute53ResolverRule_" PKG=route53resolver
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53resolver/... -v -count 1 -parallel 20  -run=TestAccRoute53ResolverRule_ -timeout 360m
=== RUN   TestAccRoute53ResolverRule_basic
=== PAUSE TestAccRoute53ResolverRule_basic
=== RUN   TestAccRoute53ResolverRule_disappears
=== PAUSE TestAccRoute53ResolverRule_disappears
=== RUN   TestAccRoute53ResolverRule_tags
=== PAUSE TestAccRoute53ResolverRule_tags
=== RUN   TestAccRoute53ResolverRule_justDotDomainName
=== PAUSE TestAccRoute53ResolverRule_justDotDomainName
=== RUN   TestAccRoute53ResolverRule_trailingDotDomainName
=== PAUSE TestAccRoute53ResolverRule_trailingDotDomainName
=== RUN   TestAccRoute53ResolverRule_updateName
=== PAUSE TestAccRoute53ResolverRule_updateName
=== RUN   TestAccRoute53ResolverRule_forward
=== PAUSE TestAccRoute53ResolverRule_forward
=== RUN   TestAccRoute53ResolverRule_forwardMultiProtocol
=== PAUSE TestAccRoute53ResolverRule_forwardMultiProtocol
=== RUN   TestAccRoute53ResolverRule_forward_ipv6
=== PAUSE TestAccRoute53ResolverRule_forward_ipv6
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== CONT  TestAccRoute53ResolverRule_basic
=== CONT  TestAccRoute53ResolverRule_justDotDomainName
=== CONT  TestAccRoute53ResolverRule_forward
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate
=== CONT  TestAccRoute53ResolverRule_forward_ipv6
=== CONT  TestAccRoute53ResolverRule_forwardMultiProtocol
=== CONT  TestAccRoute53ResolverRule_updateName
=== CONT  TestAccRoute53ResolverRule_trailingDotDomainName
=== CONT  TestAccRoute53ResolverRule_tags
=== CONT  TestAccRoute53ResolverRule_disappears
--- PASS: TestAccRoute53ResolverRule_disappears (17.11s)
--- PASS: TestAccRoute53ResolverRule_justDotDomainName (19.80s)
--- PASS: TestAccRoute53ResolverRule_trailingDotDomainName (19.81s)
--- PASS: TestAccRoute53ResolverRule_basic (19.88s)
--- PASS: TestAccRoute53ResolverRule_updateName (27.56s)
--- PASS: TestAccRoute53ResolverRule_tags (34.85s)
--- PASS: TestAccRoute53ResolverRule_forward (230.40s)
--- PASS: TestAccRoute53ResolverRule_forwardMultiProtocol (240.15s)
--- PASS: TestAccRoute53ResolverRule_forward_ipv6 (261.12s)
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6 (430.82s)
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate (449.31s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    454.450s

[github-actions]

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.