instances add ipv6 attribute

[NabilHouidi]

Description

Adds ipv6 addresses to aws-instances data source.

Tests gad to be updates because the default vpc does not have ipv6 enabled out of the box

Relations

Closes #29708

References

Output from Acceptance Testing

make testacc TESTS=TestAccEC2InstancesDataSource_basic PKG=ec2                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstancesDataSource_basic'  -timeout 180m
=== RUN   TestAccEC2InstancesDataSource_basic
=== PAUSE TestAccEC2InstancesDataSource_basic
=== CONT  TestAccEC2InstancesDataSource_basic
--- PASS: TestAccEC2InstancesDataSource_basic (117.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	117.578s

make testacc TESTS=TestAccEC2InstancesDataSource_timeout PKG=ec2              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstancesDataSource_timeout'  -timeout 180m
=== RUN   TestAccEC2InstancesDataSource_timeout
=== PAUSE TestAccEC2InstancesDataSource_timeout
=== CONT  TestAccEC2InstancesDataSource_timeout
--- PASS: TestAccEC2InstancesDataSource_timeout (128.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	128.386s

make testacc TESTS=TestAccEC2InstancesDataSource_empty PKG=ec2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstancesDataSource_empty'  -timeout 180m
=== RUN   TestAccEC2InstancesDataSource_empty
=== PAUSE TestAccEC2InstancesDataSource_empty
=== CONT  TestAccEC2InstancesDataSource_empty
--- PASS: TestAccEC2InstancesDataSource_empty (30.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	30.848s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2InstancesDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2InstancesDataSource_ -timeout 180m
=== RUN   TestAccEC2InstancesDataSource_basic
=== PAUSE TestAccEC2InstancesDataSource_basic
=== RUN   TestAccEC2InstancesDataSource_tags
=== PAUSE TestAccEC2InstancesDataSource_tags
=== RUN   TestAccEC2InstancesDataSource_instanceStateNames
=== PAUSE TestAccEC2InstancesDataSource_instanceStateNames
=== RUN   TestAccEC2InstancesDataSource_empty
=== PAUSE TestAccEC2InstancesDataSource_empty
=== RUN   TestAccEC2InstancesDataSource_timeout
=== PAUSE TestAccEC2InstancesDataSource_timeout
=== CONT  TestAccEC2InstancesDataSource_basic
=== CONT  TestAccEC2InstancesDataSource_empty
=== CONT  TestAccEC2InstancesDataSource_timeout
--- PASS: TestAccEC2InstancesDataSource_empty (14.09s)
=== CONT  TestAccEC2InstancesDataSource_instanceStateNames
--- PASS: TestAccEC2InstancesDataSource_timeout (110.85s)
=== CONT  TestAccEC2InstancesDataSource_tags
--- PASS: TestAccEC2InstancesDataSource_basic (114.19s)
--- PASS: TestAccEC2InstancesDataSource_instanceStateNames (108.73s)
--- PASS: TestAccEC2InstancesDataSource_tags (119.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	236.020s

[ewbankkit]

@NabilHouidi Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[sylr]

Thank you @NabilHouidi!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.