Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource: codegurureviewer_repository_association #29656

Conversation

silvaalbert
Copy link
Contributor

Description

Adding resource for: codegurureviewer_repository_association

Relations

Relates #29616

References

https://docs.aws.amazon.com/codeguru/latest/reviewer-api/API_AssociateRepository.html
https://docs.aws.amazon.com/codeguru/latest/reviewer-api/API_ListRepositoryAssociations.html

Output from Acceptance Testing

make testacc TESTS=TestAccCodeGuruReviewerRepositoryAssociation PKG=codegurureviewer ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codegurureviewer/... -v -count 1 -parallel 5 -run='TestAccCodeGuruReviewerRepositoryAssociation'  -timeout 180m
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_basic
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_basic
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_tags
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_tags
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_basic
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_tags
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_disappears (67.03s)
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_basic (67.39s)
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_S3Repository (67.79s)
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_KMSKey (77.47s)
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_tags (79.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codegurureviewer	82.268s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 25, 2023
@silvaalbert silvaalbert marked this pull request as ready for review February 25, 2023 19:57
@silvaalbert silvaalbert marked this pull request as draft March 1, 2023 12:31
@silvaalbert silvaalbert marked this pull request as ready for review March 1, 2023 13:17
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Mar 5, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeGuruReviewerRepositoryAssociation_' PKG=codegurureviewer ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codegurureviewer/... -v -count 1 -parallel 3  -run=TestAccCodeGuruReviewerRepositoryAssociation_ -timeout 180m
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_basic
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_basic
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_tags
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_tags
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_basic
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_tags
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_disappears
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_disappears (89.55s)
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_basic (100.77s)
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_tags (121.18s)
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_S3Repository (80.46s)
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_KMSKey (76.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codegurureviewer	185.914s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit self-assigned this Mar 12, 2023
@ewbankkit ewbankkit merged commit 66884a8 into hashicorp:main Mar 13, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 13, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants