Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeouts to QLDB ledger #29635

Merged
merged 11 commits into from
Mar 10, 2023
Merged

Added timeouts to QLDB ledger #29635

merged 11 commits into from
Mar 10, 2023

Conversation

bjernie
Copy link
Contributor

@bjernie bjernie commented Feb 24, 2023

Description

Added timeouts for aws_qldb_ledger

Relations

Closes #28231

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/qldb Issues and PRs that pertain to the qldb service. labels Feb 24, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@bjernie
Copy link
Contributor Author

bjernie commented Mar 8, 2023

Could a maintainer please look at this?

@johnsonaj johnsonaj self-assigned this Mar 10, 2023
@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Mar 10, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccQLDBLedger_' PKG=qldb

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 20  -run=TestAccQLDBLedger_ -timeout 180m
--- PASS: TestAccQLDBLedger_kmsKey (322.94s)
--- PASS: TestAccQLDBLedger_disappears (326.60s)
--- PASS: TestAccQLDBLedger_update (328.12s)
--- PASS: TestAccQLDBLedger_nameGenerated (328.40s)
--- PASS: TestAccQLDBLedger_tags (341.92s)
--- PASS: TestAccQLDBLedger_basic (586.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	589.094s

@johnsonaj
Copy link
Contributor

@bjernie thanks for the contribution? 🎉

@johnsonaj johnsonaj merged commit a9ad032 into hashicorp:main Mar 10, 2023
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Mar 10, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 10, 2023
@bjernie bjernie deleted the f-added-timeouts-to-qldb-ledger branch March 10, 2023 16:58
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/qldb Issues and PRs that pertain to the qldb service. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants