Acceptance tests fixes

[ewbankkit]

Description

Fixes CI acceptance test failures:

=== RUN   TestAccAccountAlternateContact_basic
alternate_contact_test.go:27: Step 1/3 error: Check failed: 3 errors occurred:
  * Check 4/7 error: aws_account_alternate_contact.test: Attribute 'email_address' expected "[email protected]", got "[email protected]"
  * Check 5/7 error: aws_account_alternate_contact.test: Attribute 'name' expected "tf-acc-test-2877305976920142189", got "tf-acc-test-6030697337840501828"
  * Check 7/7 error: aws_account_alternate_contact.test: Attribute 'title' expected "tf-acc-test-2877305976920142189", got "tf-acc-test-6030697337840501828"
--- FAIL: TestAccAccountAlternateContact_basic (15.51s)
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_enabled
certificate_authority_test.go:355: Step 3/5 error: Error running apply: exit status 1
Error: updating ACM PCA Certificate Authority: ValidationException: CRL configuration parameters can only be set when CRLs are enabled.
  status code: 400, request id: 1967e77d-bea6-4093-9534-675b7fbd350a
with aws_acmpca_certificate_authority.test,
on terraform_plugin_test.tf line 33, in resource "aws_acmpca_certificate_authority" "test":
33: resource "aws_acmpca_certificate_authority" "test" {
--- FAIL: TestAccACMPCACertificateAuthority_RevocationCrl_enabled (229.09s)
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
certificate_authority_test.go:428: Step 4/4 error: Error running apply: exit status 1
Error: updating ACM PCA Certificate Authority: ValidationException: CRL configuration parameters can only be set when CRLs are enabled.
  status code: 400, request id: 98808618-3526-4ee2-b6ee-f775be3eec9d
with aws_acmpca_certificate_authority.test,
on terraform_plugin_test.tf line 2, in resource "aws_acmpca_certificate_authority" "test":
2: resource "aws_acmpca_certificate_authority" "test" {
--- FAIL: TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays (311.70s)
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
certificate_authority_test.go:266: Step 6/6 error: Error running apply: exit status 1
Error: updating ACM PCA Certificate Authority: ValidationException: CRL configuration parameters can only be set when CRLs are enabled.
  status code: 400, request id: eeb4ccb0-9e3b-48d3-9eed-98063653469d
with aws_acmpca_certificate_authority.test,
on terraform_plugin_test.tf line 2, in resource "aws_acmpca_certificate_authority" "test":
2: resource "aws_acmpca_certificate_authority" "test" {
--- FAIL: TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME (361.47s)
=== RUN   TestAccAPIGatewayUsagePlan_throttling
=== PAUSE TestAccAPIGatewayUsagePlan_throttling
=== CONT  TestAccAPIGatewayUsagePlan_throttling
usage_plan_test.go:220: Step 1/5 error: Check failed: Check 3/3 error: aws_api_gateway_usage_plan.test: list or set attribute 'throttle_settings' must be checked by element count key (throttle_settings.#) or element value keys (e.g. throttle_settings.0). Set element value checks should use TestCheckTypeSet functions instead.
--- FAIL: TestAccAPIGatewayUsagePlan_throttling (22.05s)
=== RUN   TestAccAPIGatewayUsagePlan_apiStages
=== PAUSE TestAccAPIGatewayUsagePlan_apiStages
=== CONT  TestAccAPIGatewayUsagePlan_apiStages
usage_plan_test.go:361: Step 3/7 error: Check failed: Check 3/3 error: aws_api_gateway_usage_plan.test: list or set attribute 'api_stages' must be checked by element count key (api_stages.#) or element value keys (e.g. api_stages.0). Set element value checks should use TestCheckTypeSet functions instead.
--- FAIL: TestAccAPIGatewayUsagePlan_apiStages (23.22s)
=== RUN   TestAccAPIGatewayUsagePlan_quota
=== PAUSE TestAccAPIGatewayUsagePlan_quota
=== CONT  TestAccAPIGatewayUsagePlan_quota
usage_plan_test.go:304: Step 1/5 error: Check failed: Check 3/3 error: aws_api_gateway_usage_plan.test: list or set attribute 'quota_settings' must be checked by element count key (quota_settings.#) or element value keys (e.g. quota_settings.0). Set element value checks should use TestCheckTypeSet functions instead.
--- FAIL: TestAccAPIGatewayUsagePlan_quota (732.67s)

Relations

Closes #29101.
Closes #29088.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccACMPCACertificateAuthority_' PKG=acmpca ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 3  -run=TestAccACMPCACertificateAuthority_ -timeout 180m
=== RUN   TestAccACMPCACertificateAuthority_basic
=== PAUSE TestAccACMPCACertificateAuthority_basic
=== RUN   TestAccACMPCACertificateAuthority_disappears
=== PAUSE TestAccACMPCACertificateAuthority_disappears
=== RUN   TestAccACMPCACertificateAuthority_enabledDeprecated
=== PAUSE TestAccACMPCACertificateAuthority_enabledDeprecated
=== RUN   TestAccACMPCACertificateAuthority_usageMode
=== PAUSE TestAccACMPCACertificateAuthority_usageMode
=== RUN   TestAccACMPCACertificateAuthority_deleteFromActiveState
=== PAUSE TestAccACMPCACertificateAuthority_deleteFromActiveState
=== RUN   TestAccACMPCACertificateAuthority_RevocationConfiguration_empty
=== PAUSE TestAccACMPCACertificateAuthority_RevocationConfiguration_empty
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
=== RUN   TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
=== PAUSE TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
=== RUN   TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
=== PAUSE TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
=== RUN   TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
=== PAUSE TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
=== RUN   TestAccACMPCACertificateAuthority_tags
=== PAUSE TestAccACMPCACertificateAuthority_tags
=== CONT  TestAccACMPCACertificateAuthority_basic
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_enabled
=== CONT  TestAccACMPCACertificateAuthority_RevocationOcsp_enabled
--- PASS: TestAccACMPCACertificateAuthority_basic (23.14s)
=== CONT  TestAccACMPCACertificateAuthority_tags
--- PASS: TestAccACMPCACertificateAuthority_tags (40.97s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME
--- PASS: TestAccACMPCACertificateAuthority_RevocationOcsp_enabled (62.38s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_enabled (78.24s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL
--- PASS: TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME (69.99s)
=== CONT  TestAccACMPCACertificateAuthority_enabledDeprecated
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL (43.98s)
=== CONT  TestAccACMPCACertificateAuthority_usageMode
--- PASS: TestAccACMPCACertificateAuthority_usageMode (20.34s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays
--- PASS: TestAccACMPCACertificateAuthority_enabledDeprecated (46.63s)
=== CONT  TestAccACMPCACertificateAuthority_disappears
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME (89.32s)
=== CONT  TestAccACMPCACertificateAuthority_RevocationConfiguration_empty
--- PASS: TestAccACMPCACertificateAuthority_disappears (13.60s)
=== CONT  TestAccACMPCACertificateAuthority_deleteFromActiveState
--- PASS: TestAccACMPCACertificateAuthority_RevocationConfiguration_empty (19.03s)
--- PASS: TestAccACMPCACertificateAuthority_deleteFromActiveState (20.14s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays (54.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	202.732s
% make testacc TESTARGS='-run=TestAccAccount_serial/AlternateContact' PKG=account
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial/AlternateContact -timeout 180m
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/AlternateContact
=== RUN   TestAccAccount_serial/AlternateContact/disappears
=== RUN   TestAccAccount_serial/AlternateContact/AccountID
=== RUN   TestAccAccount_serial/AlternateContact/basic
--- PASS: TestAccAccount_serial (82.78s)
    --- PASS: TestAccAccount_serial/AlternateContact (82.78s)
        --- PASS: TestAccAccount_serial/AlternateContact/disappears (14.22s)
        --- PASS: TestAccAccount_serial/AlternateContact/AccountID (40.61s)
        --- PASS: TestAccAccount_serial/AlternateContact/basic (27.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	87.751s
% make testacc TESTARGS='-run=TestAccAPIGatewayUsagePlan_' PKG=apigateway ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 3  -run=TestAccAPIGatewayUsagePlan_ -timeout 180m
=== RUN   TestAccAPIGatewayUsagePlan_basic
=== PAUSE TestAccAPIGatewayUsagePlan_basic
=== RUN   TestAccAPIGatewayUsagePlan_tags
=== PAUSE TestAccAPIGatewayUsagePlan_tags
=== RUN   TestAccAPIGatewayUsagePlan_description
=== PAUSE TestAccAPIGatewayUsagePlan_description
=== RUN   TestAccAPIGatewayUsagePlan_productCode
=== PAUSE TestAccAPIGatewayUsagePlan_productCode
=== RUN   TestAccAPIGatewayUsagePlan_throttling
=== PAUSE TestAccAPIGatewayUsagePlan_throttling
=== RUN   TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit
=== PAUSE TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit
=== RUN   TestAccAPIGatewayUsagePlan_quota
=== PAUSE TestAccAPIGatewayUsagePlan_quota
=== RUN   TestAccAPIGatewayUsagePlan_apiStages
=== PAUSE TestAccAPIGatewayUsagePlan_apiStages
=== RUN   TestAccAPIGatewayUsagePlan_APIStages_multiple
=== PAUSE TestAccAPIGatewayUsagePlan_APIStages_multiple
=== RUN   TestAccAPIGatewayUsagePlan_APIStages_throttle
=== PAUSE TestAccAPIGatewayUsagePlan_APIStages_throttle
=== RUN   TestAccAPIGatewayUsagePlan_disappears
=== PAUSE TestAccAPIGatewayUsagePlan_disappears
=== CONT  TestAccAPIGatewayUsagePlan_basic
=== CONT  TestAccAPIGatewayUsagePlan_quota
=== CONT  TestAccAPIGatewayUsagePlan_APIStages_throttle
--- PASS: TestAccAPIGatewayUsagePlan_basic (35.79s)
=== CONT  TestAccAPIGatewayUsagePlan_disappears
--- PASS: TestAccAPIGatewayUsagePlan_quota (97.75s)
=== CONT  TestAccAPIGatewayUsagePlan_APIStages_multiple
--- PASS: TestAccAPIGatewayUsagePlan_disappears (78.42s)
=== CONT  TestAccAPIGatewayUsagePlan_apiStages
--- PASS: TestAccAPIGatewayUsagePlan_APIStages_multiple (47.25s)
=== CONT  TestAccAPIGatewayUsagePlan_productCode
--- PASS: TestAccAPIGatewayUsagePlan_apiStages (89.03s)
=== CONT  TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit
--- PASS: TestAccAPIGatewayUsagePlan_throttlingInitialRateLimit (22.11s)
=== CONT  TestAccAPIGatewayUsagePlan_throttling
--- PASS: TestAccAPIGatewayUsagePlan_productCode (115.55s)
=== CONT  TestAccAPIGatewayUsagePlan_description
--- PASS: TestAccAPIGatewayUsagePlan_throttling (61.31s)
=== CONT  TestAccAPIGatewayUsagePlan_tags
--- PASS: TestAccAPIGatewayUsagePlan_tags (47.45s)
--- PASS: TestAccAPIGatewayUsagePlan_description (86.51s)
--- PASS: TestAccAPIGatewayUsagePlan_APIStages_throttle (398.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	404.074s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v4.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.