Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_networkmanager_core_network: Remove deprecated policy_document attribute #29287

Closed
jar-b opened this issue Feb 7, 2023 · 4 comments · Fixed by #30875
Closed

r/aws_networkmanager_core_network: Remove deprecated policy_document attribute #29287

jar-b opened this issue Feb 7, 2023 · 4 comments · Fixed by #30875
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/networkmanager Issues and PRs that pertain to the networkmanager service.
Milestone

Comments

@jar-b
Copy link
Member

jar-b commented Feb 7, 2023

Description

Issue for tracking the removal of the deprecated policy_document attribute in the v5.0.0 provider release.

"policy_document": {
Deprecated: "Use the aws_networkmanager_core_network_policy_attachment resource instead. " +
"This attribute will be removed in the next major version of the provider.",
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validation.All(
validation.StringLenBetween(0, 10000000),
validation.StringIsJSON,
),
DiffSuppressFunc: verify.SuppressEquivalentJSONDiffs,
StateFunc: func(v interface{}) string {
json, _ := structure.NormalizeJsonString(v)
return json
},
ConflictsWith: []string{"create_base_policy"},
},

We may also want to consider removing the computed segments and edges attributes, and either adding them to the aws_networkmanager_core_network_policy_attachment resource or creating a new aws_networkmanager_core_network data source.

References

Relates #29097

Would you like to implement a fix?

None

@jar-b jar-b added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/networkmanager Issues and PRs that pertain to the networkmanager service. labels Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot removed the service/networkmanager Issues and PRs that pertain to the networkmanager service. label Feb 7, 2023
@jar-b jar-b added this to the v5.0.0 milestone Feb 7, 2023
@jar-b jar-b added the service/networkmanager Issues and PRs that pertain to the networkmanager service. label Feb 7, 2023
@YakDriver YakDriver self-assigned this Apr 20, 2023
@github-actions github-actions bot modified the milestones: v5.0.0, v4.65.0 Apr 25, 2023
@jar-b jar-b modified the milestones: v4.65.0, v5.0.0 Apr 26, 2023
@jar-b
Copy link
Member Author

jar-b commented May 23, 2023

Closed by #30875, merged to main via #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/networkmanager Issues and PRs that pertain to the networkmanager service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants