-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kms_key_id
attribute to CloudTrail Event Data Store
#29224
Add kms_key_id
attribute to CloudTrail Event Data Store
#29224
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Fixed the failing check @ewbankkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCloudTrailEventDataStore_' PKG=cloudtrail ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudtrail/... -v -count 1 -parallel 3 -run=TestAccCloudTrailEventDataStore_ -timeout 180m
=== RUN TestAccCloudTrailEventDataStore_basic
=== PAUSE TestAccCloudTrailEventDataStore_basic
=== RUN TestAccCloudTrailEventDataStore_kmsKeyId
=== PAUSE TestAccCloudTrailEventDataStore_kmsKeyId
=== RUN TestAccCloudTrailEventDataStore_disappears
=== PAUSE TestAccCloudTrailEventDataStore_disappears
=== RUN TestAccCloudTrailEventDataStore_tags
=== PAUSE TestAccCloudTrailEventDataStore_tags
=== RUN TestAccCloudTrailEventDataStore_options
=== PAUSE TestAccCloudTrailEventDataStore_options
=== RUN TestAccCloudTrailEventDataStore_advancedEventSelector
=== PAUSE TestAccCloudTrailEventDataStore_advancedEventSelector
=== CONT TestAccCloudTrailEventDataStore_basic
=== CONT TestAccCloudTrailEventDataStore_advancedEventSelector
=== CONT TestAccCloudTrailEventDataStore_options
acctest.go:842: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudTrailEventDataStore_options (1.17s)
=== CONT TestAccCloudTrailEventDataStore_tags
--- PASS: TestAccCloudTrailEventDataStore_advancedEventSelector (20.38s)
=== CONT TestAccCloudTrailEventDataStore_disappears
--- PASS: TestAccCloudTrailEventDataStore_basic (21.83s)
=== CONT TestAccCloudTrailEventDataStore_kmsKeyId
--- PASS: TestAccCloudTrailEventDataStore_disappears (14.25s)
--- PASS: TestAccCloudTrailEventDataStore_tags (45.63s)
--- PASS: TestAccCloudTrailEventDataStore_kmsKeyId (25.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail 52.855s
@bschaatsbergen Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds a new attribute
kms_key_id
to theaws_cloudtrail_event_data_store
Relations
Closes #29219
References
Output from Acceptance Testing