-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved RequiredWith from wrong attribute on an appmesh route #29217
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…vice_name to spec.0.grpc_route.0.match.0.method_name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
plan
now returns the proper error message:
│ Error: Missing required argument
│
│ with aws_appmesh_route.test,
│ on main.tf line 58, in resource "aws_appmesh_route" "test":
│ 58: match {
│
│ "spec.0.grpc_route.0.match.0.method_name": all of `spec.0.grpc_route.0.match.0.method_name,spec.0.grpc_route.0.match.0.service_name` must be specified
GRPC Route Match Docs: https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_GrpcRouteMatch.html
Thanks for your contribution, @bjernie! 👏 |
This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
If you create an aws_appmesh_route and provide a spec.0.grpc_route.0.match.service_name it gives an error that you also need to specify a spec.0.grpc_route.0.match.method_name when it is actually the other way around.