Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for auto-enabling lambda scanning on aws_inspector2_organization_configuration #28961

Conversation

srgustafson8
Copy link
Contributor

@srgustafson8 srgustafson8 commented Jan 18, 2023

Description

Adds the lambda scanning auto-enable option to the Inspector v2 Organisation configuration.

Added as an optional attribute to prevent this being a breaking change, and because the underlying API also doesn't seem to require it as an attribute.

Relations

Closes #28823.
Closes #28953.

References

https://docs.aws.amazon.com/inspector/v2/APIReference/API_UpdateOrganizationConfiguration.html

Output from Acceptance Testing

❯ make testacc TESTS=TestAccInspector2OrganizationConfiguration PKG=inspector2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/inspector2/... -v -count 1 -parallel 20 -run='TestAccInspector2OrganizationConfiguration'  -timeout 180m
=== RUN   TestAccInspector2OrganizationConfiguration_serial
=== PAUSE TestAccInspector2OrganizationConfiguration_serial
=== CONT  TestAccInspector2OrganizationConfiguration_serial
=== RUN   TestAccInspector2OrganizationConfiguration_serial/disappears
=== RUN   TestAccInspector2OrganizationConfiguration_serial/ec2ECR
=== RUN   TestAccInspector2OrganizationConfiguration_serial/lambda
=== RUN   TestAccInspector2OrganizationConfiguration_serial/basic
--- PASS: TestAccInspector2OrganizationConfiguration_serial (167.13s)
    --- PASS: TestAccInspector2OrganizationConfiguration_serial/disappears (50.95s)
    --- PASS: TestAccInspector2OrganizationConfiguration_serial/ec2ECR (38.43s)
    --- PASS: TestAccInspector2OrganizationConfiguration_serial/lambda (40.97s)
    --- PASS: TestAccInspector2OrganizationConfiguration_serial/basic (36.78s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/inspector2 170.286s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/inspector2 Issues and PRs that pertain to the inspector2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jan 18, 2023
@srgustafson8 srgustafson8 changed the title implement lambda autoenable for inspectorv2 [Enhancement]: Add support for auto-enabling lambda scanning on aws_inspector2_organization_configuration Jan 18, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 18, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccInspector2OrganizationConfiguration_serial' PKG=inspector2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/inspector2/... -v -count 1 -parallel 20  -run=TestAccInspector2OrganizationConfiguration_serial -timeout 180m
=== RUN   TestAccInspector2OrganizationConfiguration_serial
=== PAUSE TestAccInspector2OrganizationConfiguration_serial
=== CONT  TestAccInspector2OrganizationConfiguration_serial
=== RUN   TestAccInspector2OrganizationConfiguration_serial/basic
=== RUN   TestAccInspector2OrganizationConfiguration_serial/disappears
=== RUN   TestAccInspector2OrganizationConfiguration_serial/ec2ECR
=== RUN   TestAccInspector2OrganizationConfiguration_serial/lambda
--- PASS: TestAccInspector2OrganizationConfiguration_serial (120.20s)
    --- PASS: TestAccInspector2OrganizationConfiguration_serial/basic (29.33s)
    --- PASS: TestAccInspector2OrganizationConfiguration_serial/disappears (34.75s)
    --- PASS: TestAccInspector2OrganizationConfiguration_serial/ec2ECR (28.55s)
    --- PASS: TestAccInspector2OrganizationConfiguration_serial/lambda (27.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector2	125.346s

@ewbankkit
Copy link
Contributor

@srgustafson8 @lvthillo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ef116f6 into hashicorp:main Mar 13, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 13, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/inspector2 Issues and PRs that pertain to the inspector2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for auto-enabling lambda scanning on aws_inspector2_organization_configuration
5 participants