-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Add support for auto-enabling lambda scanning on aws_inspector2_organization_configuration #28961
[Enhancement]: Add support for auto-enabling lambda scanning on aws_inspector2_organization_configuration #28961
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…r2_organization_configuration" This reverts commit 750866f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccInspector2OrganizationConfiguration_serial' PKG=inspector2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/inspector2/... -v -count 1 -parallel 20 -run=TestAccInspector2OrganizationConfiguration_serial -timeout 180m
=== RUN TestAccInspector2OrganizationConfiguration_serial
=== PAUSE TestAccInspector2OrganizationConfiguration_serial
=== CONT TestAccInspector2OrganizationConfiguration_serial
=== RUN TestAccInspector2OrganizationConfiguration_serial/basic
=== RUN TestAccInspector2OrganizationConfiguration_serial/disappears
=== RUN TestAccInspector2OrganizationConfiguration_serial/ec2ECR
=== RUN TestAccInspector2OrganizationConfiguration_serial/lambda
--- PASS: TestAccInspector2OrganizationConfiguration_serial (120.20s)
--- PASS: TestAccInspector2OrganizationConfiguration_serial/basic (29.33s)
--- PASS: TestAccInspector2OrganizationConfiguration_serial/disappears (34.75s)
--- PASS: TestAccInspector2OrganizationConfiguration_serial/ec2ECR (28.55s)
--- PASS: TestAccInspector2OrganizationConfiguration_serial/lambda (27.57s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/inspector2 125.346s
@srgustafson8 @lvthillo Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the lambda scanning auto-enable option to the Inspector v2 Organisation configuration.
Added as an optional attribute to prevent this being a breaking change, and because the underlying API also doesn't seem to require it as an attribute.
Relations
Closes #28823.
Closes #28953.
References
https://docs.aws.amazon.com/inspector/v2/APIReference/API_UpdateOrganizationConfiguration.html
Output from Acceptance Testing